BUG? Duplicate key code 0xe045 in dell-wmi.c

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	BUG? Duplicate key code 0xe045 in dell-wmi.c
Date	2015-07-05 11:00 +0200
Message-ID	<pINWj-Dz-19@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hello,

I'm looking at dell-wmi.c driver and its history in git and I found 
problem with handling WMI key code 0xe045. In current dell-wmi.c code is

{KE_KEY, 0xe045, KEY_PROG1},
{KE_IGNORE, 0xe045, KEY_NUMLOCK},

I bet this is some copy-paste error as one code can be translated only 
to one input key event.

In git history I found that above change was added by commit:

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5cab0098171712a9fd51399b06181c8dfdebe9c9

===============================================
commit 5cab0098171712a9fd51399b06181c8dfdebe9c9
Author: Mario Limonciello <mario_limonciello@dell.com>
Date:   Wed Jun 10 19:40:47 2009 +0000

    dell-wmi: add additional keyboard events
    
    Upcoming Dell hardware will send more keyboard events via WMI.  Add
    support for them.
    
    Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Len Brown <len.brown@intel.com>
===============================================

Sending email to all signers of this commit. Problematic code is still 
in upstream kernel, so it needs to be fixed.

Mario Limonciello: Do you know if code 0xe045 is some PROG1 or NUMLOCK?

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

BUG? Duplicate key code 0xe045 in dell-wmi.c Pali Rohár <pali.rohar@gmail.com> - 2015-07-05 11:00 +0200

csiph-web