Re: [PATCH v4 14/17] x86/asm/entry/64: Migrate error and interrupt exit work to C

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 14/17] x86/asm/entry/64: Migrate error and interrupt exit work to C
Date	2015-07-05 10:50 +0200
Message-ID	<pINMC-Ad-31@gated-at.bofh.it> (permalink)
References	(1 earlier) <pGN4o-43C-41@gated-at.bofh.it> <pHLDc-2yu-15@gated-at.bofh.it> <pHPdM-4VR-1@gated-at.bofh.it> <pIaie-1dJ-25@gated-at.bofh.it> <pIc0H-2mW-59@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Andy Lutomirski <luto@amacapital.net> wrote:

> >> I'm torn on this one.  In principle, you're right, or we could have a macro 
> >> CALL_ENTER_FROM_USER_MODE that does nothing if context tracking is off.  
> >> OTOH, that's also kind of messy.
> >
> > busybox has IF() macros:
> >
> > IF_CONTEXT_TRACKING(call enter_from_user_mode)
> >
> > Unlike #if, this needs one line, not three.
> 
> I predict all of these call sites will get moved to C before 4.3.  If not, then 
> I'd be glad to clean this part up.

Ok, let's see how it works out.

I think in the initial phase we should be conservative and should attempt to 
introduce as few unrelated changes as possible, and get the conversion done. The 
current x86 entry code is a reasonable base to start with.

Once most of the 'mechanic' conversion is done we can do all the other changes.

The conversion itself is risky enough as-is, we want to offload as much of any 
other risk to after the conversion is done.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 14/17] x86/asm/entry/64: Migrate error and interrupt  exit work to C Denys Vlasenko <vda.linux@googlemail.com> - 2015-07-03 16:40 +0200
  Re: [PATCH v4 14/17] x86/asm/entry/64: Migrate error and interrupt  exit work to C Andy Lutomirski <luto@amacapital.net> - 2015-07-03 18:30 +0200
    Re: [PATCH v4 14/17] x86/asm/entry/64: Migrate error and interrupt  exit work to C Ingo Molnar <mingo@kernel.org> - 2015-07-05 10:50 +0200

csiph-web