Re: [PATCH, resend] build: fix broken kernel RPM source symlink

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Paul Bolle <pebolle@tiscali.nl>
Newsgroups	linux.kernel
Subject	Re: [PATCH, resend] build: fix broken kernel RPM source symlink
Date	Sun, 05 Jul 2015 10:50:02 +0200
Message-ID	<pINMC-Ad-23@gated-at.bofh.it> (permalink)
References	<pH2d4-I6-13@gated-at.bofh.it>
X-Original-To	Espen Carlsen <ec@numascale.com>, Michal Marek <mmarek@suse.cz>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.16.3 (3.16.3-2.fc22)
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel J Blueman <daniel@numascale.com>, Steffen Persvold <sp@numascale.com>
X-Original-Date	Sat, 04 Jul 2015 12:19:29 +0200
X-Original-Message-ID	<1436005169.20057.60.camel@tiscali.nl>
X-Original-References	<1435664842-17908-1-git-send-email-ec@numascale.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1176884

Show key headers only | View raw

On di, 2015-06-30 at 13:47 +0200, Espen Carlsen wrote:
> Fix the 'rpm-pkg' makefile target to always generate the correct
> /usr/src/kernel/<ver> symlink; this fails on non-RPM-native systems

          /kernels/

> eg Ubuntu.
> 
> On a non-RPM-native system, the symlink created by rpmbuild points to
> the source tree, so the ln -sf commands to overwrite build and source 
> will
> create a new link inside the directory pointed to by the build and 
> source
> symlinks. This will break the -devel.rpm, as the build and source 
> symlinks
> will point to non existing directories after installing them.

Perhaps this is all obvious but what exactly happens currently and what
happens after this change? (An example might help readers that are just
as easily confused as I am. Perhaps that might also explain why this is
only an issue on non-RPM-native systems.)

It doesn't help that the description of -T in "man ln" is rather
unhelpful. "info ln" was better, after following some references, but
I'm still not sure what it buys you for this issue.
 
> --- a/scripts/package/mkspec
> +++ b/scripts/package/mkspec

> -echo "ln -sf /usr/src/kernels/$KERNELRELEASE build"
> -echo "ln -sf /usr/src/kernels/$KERNELRELEASE source"
> +echo "ln -sfT /usr/src/kernels/$KERNELRELEASE build"
> +echo "ln -sfT /usr/src/kernels/$KERNELRELEASE source"

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH, resend] build: fix broken kernel RPM source symlink Paul Bolle <pebolle@tiscali.nl> - 2015-07-05 10:50 +0200

csiph-web