Re: [PATCH v7 09/11] KVM: arm64: guest debug, HW assisted debug support

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 09/11] KVM: arm64: guest debug, HW assisted debug support
Date	2015-07-03 11:30 +0200
Message-ID	<pI5se-6JS-29@gated-at.bofh.it> (permalink)
References	<pHuVI-bP-19@gated-at.bofh.it> <pHv5n-f6-11@gated-at.bofh.it> <pHIlY-nD-11@gated-at.bofh.it> <pHNbY-3p1-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Alex,

On Thu, Jul 02, 2015 at 02:50:33PM +0100, Alex Bennée wrote:
> Are you happy with this?:

[...]

> +/**
> + * kvm_arch_dev_ioctl_check_extension
> + *
> + * We currently assume that the number of HW registers is uniform
> + * across all CPUs (see cpuinfo_sanity_check).
> + */
>  int kvm_arch_dev_ioctl_check_extension(long ext)
>  {
>         int r;
> @@ -64,6 +71,12 @@ int kvm_arch_dev_ioctl_check_extension(long ext)
>         case KVM_CAP_ARM_EL1_32BIT:
>                 r = cpu_has_32bit_el1();
>                 break;
> +       case KVM_CAP_GUEST_DEBUG_HW_BPS:
> +               r = hw_breakpoint_slots(TYPE_INST);
> +               break;
> +       case KVM_CAP_GUEST_DEBUG_HW_WPS:
> +               r  = hw_breakpoint_slots(TYPE_DATA);
> +               break;

Whilst I much prefer this code, it actually adds an unwanted dependency
on PERF_EVENTS that I didn't think about to start with. Sorry to keep
messing you about -- I guess your original patch is the best thing after
all.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v7 09/11] KVM: arm64: guest debug, HW assisted debug  support Will Deacon <will.deacon@arm.com> - 2015-07-02 10:50 +0200
  Re: [PATCH v7 09/11] KVM: arm64: guest debug, HW assisted debug support Alex Bennée <alex.bennee@linaro.org> - 2015-07-02 16:00 +0200
    Re: [PATCH v7 09/11] KVM: arm64: guest debug, HW assisted debug  support Will Deacon <will.deacon@arm.com> - 2015-07-03 11:30 +0200
      Re: [PATCH v7 09/11] KVM: arm64: guest debug, HW assisted debug support Alex Bennée <alex.bennee@linaro.org> - 2015-07-03 18:10 +0200

csiph-web