Re: [PATCH/RFC v2 1/5] leds: Use set_brightness_work for brightness_set ops that can sleep

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH/RFC v2 1/5] leds: Use set_brightness_work for brightness_set ops that can sleep
Date	2015-07-02 01:10 +0200
Message-ID	<pHziF-3cE-15@gated-at.bofh.it> (permalink)
References	<pH4oy-48U-15@gated-at.bofh.it> <pHccq-6VE-23@gated-at.bofh.it> <pHmYb-3yp-13@gated-at.bofh.it> <pHxTA-28A-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > As Andrew Lunn mentioned, he was also working on this issue and he did
> > the vast majority of work [1] needed to remove work queues from existing
> > drivers. Only new flags would have to be added.
> 
> Excellent! This is what I was thinking as well.
> 
> It think it'd be good if we could get the framework improvements in without
> having to change the existing drivers. They could be fixed later on; I
> wonder how testing could be arranged.

The work for the drivers is mostly brainless donkey work. So long as a
few people review each patch to catch dumb errors, the risk should be
quite low.

So ask people to test, but don't hold back drivers which nobody
tested, would be my suggestion.

	Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH/RFC v2 1/5] leds: Use set_brightness_work for  brightness_set ops that can sleep Sakari Ailus <sakari.ailus@iki.fi> - 2015-07-01 23:40 +0200
  Re: [PATCH/RFC v2 1/5] leds: Use set_brightness_work for  brightness_set ops that can sleep Andrew Lunn <andrew@lunn.ch> - 2015-07-02 01:10 +0200
  Re: [PATCH/RFC v2 1/5] leds: Use set_brightness_work for  brightness_set ops that can sleep Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-07-03 15:20 +0200

csiph-web