Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1175103
| From | He Kuang <hekuang@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/4] perf record: Use %ld for long type sample counter |
| Date | 2015-07-01 11:10 +0200 |
| Message-ID | <pHmbL-3go-1@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Since we post-process and count (long rec->samples) to show precise number of samples instead of estimate on (u64 rec->bytes_written), the format string of that should be changed to %ld accordingly, otherwise the value don't show right on 32bit machine. Before this patch: $ perf record -e syscalls:sys_enter_write -- dd if=/dev/zero of=/dev/null bs=4k count=1000 1000+0 records in 1000+0 records out [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.077 MB perf.data (1 samples) ] After this patch: $ perf record -e syscalls:sys_enter_write -- dd if=/dev/zero of=/dev/null bs=4k count=1000 1000+0 records in 1000+0 records out [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.077 MB perf.data (1001 samples) ] Signed-off-by: He Kuang <hekuang@huawei.com> --- tools/perf/builtin-record.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index de165a1..65e632d 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -737,7 +737,7 @@ out_child: if (rec->samples && !rec->opts.full_auxtrace) scnprintf(samples, sizeof(samples), - " (%" PRIu64 " samples)", rec->samples); + " (%ld samples)", rec->samples); else samples[0] = '\0'; -- 1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/4] perf record: Use %ld for long type sample counter He Kuang <hekuang@huawei.com> - 2015-07-01 11:10 +0200 [PATCH 4/4] perf probe: Add failure check when show variable range He Kuang <hekuang@huawei.com> - 2015-07-01 11:10 +0200 [PATCH 3/4] perf probe: Enable --range option according to libdw version He Kuang <hekuang@huawei.com> - 2015-07-01 11:10 +0200 [PATCH 2/4] perf probe: Fix failure to probe online module He Kuang <hekuang@huawei.com> - 2015-07-01 11:10 +0200
csiph-web