Re: [PATCH v2 4/9] arm: twr-k70f120m: timer driver for Kinetis SoC

From	Paul Osmialowski <pawelo@king.net.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/9] arm: twr-k70f120m: timer driver for Kinetis SoC
Date	2015-07-01 10:50 +0200
Message-ID	<pHlSp-2Rg-1@gated-at.bofh.it> (permalink)
References	<pH2Zr-1ZE-15@gated-at.bofh.it> <pH2Zs-1ZE-35@gated-at.bofh.it> <pHl62-2i0-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Thomas,

On Wed, 1 Jul 2015, Thomas Gleixner wrote:

>> +		clockevents_register_device(
>> +				&kinetis_clockevent_tmrs[chan].evtdev);
>> +
>> +		kinetis_pit_init(&kinetis_clockevent_tmrs[chan],
>> +						(rate / HZ) - 1);
>> +		kinetis_pit_enable(&kinetis_clockevent_tmrs[chan], 1);
>
> No point doing this. The core code has invoked the set_periodic call
> back via clockevents_register_device() already.
>

As I removed this kinetis_pit_enable() line, the timer did not start, 
therefore the system became unusable. What could be possible reason for 
that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/9] arm: twr-k70f120m: timer driver for Kinetis SoC Thomas Gleixner <tglx@linutronix.de> - 2015-07-01 10:00 +0200
  Re: [PATCH v2 4/9] arm: twr-k70f120m: timer driver for Kinetis SoC Paul Osmialowski <pawelo@king.net.pl> - 2015-07-01 10:50 +0200

csiph-web