Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style
Date	2015-06-30 22:30 +0200
Message-ID	<pHakj-4aX-23@gated-at.bofh.it> (permalink)
References	<pH4ox-48U-1@gated-at.bofh.it> <pH4oz-48U-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote:
> +#define UART_PUT_CR(port, v)   __raw_writel(v, (port)->membase + ATMEL_US_CR)
> +#define UART_GET_MR(port)      __raw_readl((port)->membase + ATMEL_US_MR)
> +#define UART_PUT_MR(port, v)   __raw_writel(v, (port)->membase + ATMEL_US_MR)
> +#define UART_PUT_IER(port, v)  __raw_writel(v, (port)->membase + ATMEL_US_IER)
> 

How about removing these macros entirely? I'm not aware of other drivers
doing it like this, and it does not seem to add any value?

At the same time, you could use readl_relaxed() to make the driver
endian-safe.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style Arnd Bergmann <arnd@arndb.de> - 2015-06-30 22:30 +0200
  Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to  fit coding style Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-07-01 00:00 +0200
  Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to  fit coding style Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2015-07-02 15:40 +0200

csiph-web