RE: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option

From	Chao Yu <yuchaochina@hotmail.com>
Newsgroups	linux.kernel
Subject	RE: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option
Date	2015-07-02 14:40 +0200
Message-ID	<pHLWx-2FP-1@gated-at.bofh.it> (permalink)
References	<pGM8h-2I8-11@gated-at.bofh.it> <pGMhX-2Tw-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Tuesday, June 30, 2015 2:40 AM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option
> 
> This patch adds noextent_cache mount option.

How about adding some descriptions in Documentation to help our user?

The other thing is we'd better to show 'noextent_cache' option when user
lookups the mount options.

How about adding codes as below?
if (test_opt(sbi, EXTENT_CACHE))
	seq_puts(seq, ",extent_cache");
+else
+	seq_puts(seq, ",noextent_cache");

> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

The other looks good to me, so please add:

Reviewed-by: Chao Yu <chao2.yu@samsung.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option Chao Yu <yuchaochina@hotmail.com> - 2015-07-02 14:40 +0200

csiph-web