Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

Path	csiph.com!aioe.org!news.mb-net.net!open-news-network.org!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Stephan Mueller <smueller@chronox.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info
Date	Thu, 02 Jul 2015 12:00:02 +0200
Message-ID	<pHJrI-10N-21@gated-at.bofh.it> (permalink)
References	<pHFep-6ZR-3@gated-at.bofh.it> <pHHJf-9G-5@gated-at.bofh.it> <pHJrI-10N-3@gated-at.bofh.it>
X-Original-To	Lokesh Vutla <lokeshvutla@ti.com>
User-Agent	KMail/4.14.9 (Linux/4.0.6-300.fc22.x86_64; KDE/4.14.9; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, davem@davemloft.net, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, t-kristo@ti.com, nsekhar@ti.com
X-Original-Date	Thu, 02 Jul 2015 11:56:34 +0200
X-Original-Message-ID	<11868978.OKt1rthESK@tauon.atsec.com>
X-Original-References	<1435814320-30347-1-git-send-email-lokeshvutla@ti.com> <1996807.vhgJsDVnGm@tauon.atsec.com> <55950A72.4040004@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1175879

Show key headers only | View raw

Am Donnerstag, 2. Juli 2015, 15:24:58 schrieb Lokesh Vutla:

Hi Lokesh,

>>> +{
>>> +	.cra_name		= "gcm(aes)",
>>> +	.cra_driver_name	= "gcm-aes-omap",
>>> +	.cra_priority		= 100,
>> 
>> Why did you choose the priority 100? The software implementations commonly
>> use 100. crypto/gcm.c uses the prio of the underlying cipher. In case of
>> ARM, there seem to be assembler implementations of AES which have the prio
>> of 200 or 300. So, such software implementation of gcm(aes) would have a
>> higher precedence than your hw implementation.
>
>Yes, you are right.
>Other hw algos in omap-aes also uses priority 100.
>Only sw and hw implementations are enabled right now and both are at same
>priority. And till now its lucky enough that hw algo gets picked.

Maybe those HW prios should be updated too?

Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info Lokesh Vutla <lokeshvutla@ti.com> - 2015-07-02 12:00 +0200
  Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info Stephan Mueller <smueller@chronox.de> - 2015-07-02 12:00 +0200

csiph-web