Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1175862

Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online

From "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online
Date 2015-07-02 11:30 +0200
Message-ID <pHIYG-QJ-11@gated-at.bofh.it> (permalink)
References <pHE8G-6jo-5@gated-at.bofh.it> <pHGDv-7IS-9@gated-at.bofh.it> <pHGNb-81t-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 2015/7/2 15:02, Xiao, Jin wrote:
> Hi Joerg,
>
> On 7/2/2015 2:52 PM, Joerg Roedel wrote:
>> Hi Jin,
>>
>> On Thu, Jul 02, 2015 at 12:24:34PM +0800, xiao jin wrote:
>>> [  106.107851] BUG: unable to handle kernel NULL pointer dereference at 0000000000000040
>>> [  106.116702] IP:
>>> [  106.118490]  [<ffffffff810044f6>] check_irq_vectors_for_cpu_disable+0x76/0x180
>> This might be the same issue I fixed with:
>>
>>     d97eb8966c91 x86/irq: Check for valid irq descriptor in check_irq_vectors_for_cpu_disable()
>>
>> Can you try whether applying this patch on your kernel fixes your
>> issue?
>>
> Yes, I agree d97eb8966c91 fix the IPANIC. I just notice a description from http://lkml.kernel.org/r/20150204132754.GA10078@suse.de.
>
> I wish to share the debug result and root cause from my side.

commit d97eb8966c91f2c9d05f0a22eb89ed5b76d966d1 looks like a workaround.

Could Jin's patch be merged also?
free_msi_irqs does have a race with smp_callin=>..=>__setup_vector_irq.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online "Zhang, Yanmin" <yanmin_zhang@linux.intel.com> - 2015-07-02 11:30 +0200
  Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online Thomas Gleixner <tglx@linutronix.de> - 2015-07-02 15:00 +0200
    Re: [PATCH] smpboot.c: move setup_vector_irq after set_cpu_online "Xiao, Jin" <jin.xiao@intel.com> - 2015-07-03 04:10 +0200

csiph-web