Re: [PATCH v2 17/17] arch, x86: pmem api for ensuring durability of persistent memory updates

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 17/17] arch, x86: pmem api for ensuring durability of persistent memory updates
Date	2015-06-30 12:30 +0200
Message-ID	<pH0XE-7ss-7@gated-at.bofh.it> (permalink)
References	<pFbXc-4YO-11@gated-at.bofh.it> <pFbXd-4YO-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 25, 2015 at 05:37:49AM -0400, Dan Williams wrote:
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index 867722591be2..9a528d945498 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -21,6 +21,7 @@
>  # define __rcu		__attribute__((noderef, address_space(4)))

On this side of the #ifdef CONFIG_SPARSE_RCU_POINTER statement then
__pmem isn't defined so it leads to a build error running a CHECKER on
today's linux-next.

I would define __pmem away, but I don't understand why __pmem and
CONFIG_SPARSE_RCU_POINTER are related at all.  Maybe it should be
outside the if statement?

>  #else
>  # define __rcu
> +# define __pmem		__attribute__((noderef, address_space(5)))
>  #endif
>  extern void __chk_user_ptr(const volatile void __user *);
>  extern void __chk_io_ptr(const volatile void __iomem *);
> @@ -42,6 +43,7 @@ extern void __chk_io_ptr(const volatile void __iomem *);
>  # define __cond_lock(x,c) (c)
>  # define __percpu
>  # define __rcu
> +# define __pmem
>  #endif
>  
>  /* Indirect macros required for expanded argument pasting, eg. __LINE__. */

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 17/17] arch,  x86: pmem api for ensuring durability of persistent memory updates Dan Williams <dan.j.williams@intel.com> - 2015-06-25 11:50 +0200
  Re: [PATCH v2 17/17] arch, x86: pmem api for ensuring durability of  persistent memory updates Dan Carpenter <dan.carpenter@oracle.com> - 2015-06-30 12:30 +0200

csiph-web