[PATCH] arm: perf: Set affinity for PPI based PMUs

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	[PATCH] arm: perf: Set affinity for PPI based PMUs
Date	Tue, 30 Jun 2015 00:00:03 +0200
Message-ID	<pGPfR-7lu-25@gated-at.bofh.it> (permalink)
X-Original-To	Will Deacon <will.deacon@arm.com>
X-Mailer	git-send-email 2.3.0.rc1.33.g42e4583
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland <mark.rutland@arm.com>
X-Original-Date	Mon, 29 Jun 2015 14:58:46 -0700
X-Original-Message-ID	<1435615126-16492-1-git-send-email-sboyd@codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1174133

Show key headers only | View raw

For PPI based PMUs, we bail out early in of_pmu_irq_cfg() without
setting the PMU's supported_cpus bitmap. This causes the
smp_call_function_any() in armv7_probe_num_events() to fail. Set
the bitmap to be all CPUs so that we properly probe PMUs that use
PPIs.

Fixes: cc88116da0d1 ("arm: perf: treat PMUs as CPU affine")
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 arch/arm/kernel/perf_event.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
index 54272e0be713..7d5379c1c443 100644
--- a/arch/arm/kernel/perf_event.c
+++ b/arch/arm/kernel/perf_event.c
@@ -795,8 +795,10 @@ static int of_pmu_irq_cfg(struct arm_pmu *pmu)
 
 	/* Don't bother with PPIs; they're already affine */
 	irq = platform_get_irq(pdev, 0);
-	if (irq >= 0 && irq_is_percpu(irq))
+	if (irq >= 0 && irq_is_percpu(irq)) {
+		cpumask_setall(&pmu->supported_cpus);
 		return 0;
+	}
 
 	irqs = kcalloc(pdev->num_resources, sizeof(*irqs), GFP_KERNEL);
 	if (!irqs)
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm: perf: Set affinity for PPI based PMUs Stephen Boyd <sboyd@codeaurora.org> - 2015-06-30 00:00 +0200
  Re: [PATCH] arm: perf: Set affinity for PPI based PMUs Stephen Boyd <sboyd@codeaurora.org> - 2015-07-01 03:20 +0200

csiph-web