Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1173891

Re: [PATCH] mm:Make the function alloc_mem_cgroup_per_zone_info bool

Show all headers | View raw

On Mon 29-06-15 11:23:08, Nicholas Krause wrote:
[...]
> I agree with and looked into the callers about this wasn't sure if you
> you wanted me to return - ENOMEM.  I will rewrite this patch the other
> way. 

I am not sure this path really needs a cleanup.

> Furthermore I apologize about this and do have actual useful
> patches but will my rep it's hard to get replies from maintainers.

You can hardly expect somebody will be thrilled about your patches when
their fault rate is close to 100%. Reviewing each patch takes time and
that is a scarce resource. If you want people to follow your patches
make sure you are offering something that might be interesting or
useful. Cleanups like these usually are not interesting without
either building something bigger on top of them or when they improve
readability considerably.

[...]
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm:Make the function alloc_mem_cgroup_per_zone_info bool Michal Hocko <mhocko@suse.cz> - 2015-06-29 17:10 +0200
  Re: [PATCH] mm:Make the function alloc_mem_cgroup_per_zone_info bool Michal Hocko <mhocko@suse.cz> - 2015-06-29 17:40 +0200
    Re: [PATCH] mm:Make the function alloc_mem_cgroup_per_zone_info bool Michal Hocko <mhocko@suse.cz> - 2015-06-29 18:00 +0200

csiph-web