Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1173871
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC][PATCH 05/13] percpu-rwsem: Optimize readers and reduce global impact |
| Date | 2015-06-29 17:20 +0200 |
| Message-ID | <pGJ0K-6L7-1@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <pE91o-3zX-15@gated-at.bofh.it> <pEqOC-4be-21@gated-at.bofh.it> <pFkH7-Ob-1@gated-at.bofh.it> <pFkQN-Zx-17@gated-at.bofh.it> <pGDHI-7uP-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello, Peter.
On Mon, Jun 29, 2015 at 11:32:19AM +0200, Peter Zijlstra wrote:
> Agreed, luckily we already have the infrastructure for this, something
> like so?
>
> --- a/include/linux/percpu-defs.h
> +++ b/include/linux/percpu-defs.h
> @@ -287,6 +287,16 @@ do { \
> preempt_enable(); \
> } while (0)
>
> +#define per_cpu_sum(var) \
> +({ \
> + typeof(var) __sum = 0; \
> + int cpu; \
Why not __cpu?
> + compiletime_assert_atomic_type(__sum); \
> + for_each_possible_cpu(cpu) \
> + __sum += per_cpu(var, cpu); \
> + __sum; \
> +})
But other than that, looks good to me.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [RFC][PATCH 05/13] percpu-rwsem: Optimize readers and reduce global impact Tejun Heo <tj@kernel.org> - 2015-06-29 17:20 +0200 Re: [RFC][PATCH 05/13] percpu-rwsem: Optimize readers and reduce global impact Peter Zijlstra <peterz@infradead.org> - 2015-06-29 17:20 +0200
csiph-web