Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1172586

[PATCH] Staging: rtl8192u: Replace memset with eth_zero_addr

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Vaishali Thakkar <vthakkar1994@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] Staging: rtl8192u: Replace memset with eth_zero_addr
Date Fri, 26 Jun 2015 06:30:02 +0200
Message-ID <pFtr4-4R0-1@gated-at.bofh.it> (permalink)
X-Original-To Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=YBUvc9MvUwFKNSzebo82YK50Kk7JllbAITSTgAjWHNc=; b=gMiH9rN9D56/8MNjZ4bLWxjEVJ+WSsMl1jGkxDgrS3vsSoQsWceWNGTGCtqrPA42c9 8DT5vJ14g6P20L9MffaexHEB3rypoqE0iKLdbOSpjzVu64ywJXLkJ72Jhp3vCK2dc1HY Zj3P41YvJtQ7r4IhsNG8uyr66ZQmXUeT9d0YA1zOJrXdAgr7qOLBSkGoLNHCUJufPY0R ll4a/bAj88uUoHxjj+c7NuJ6SubPSkEzmGXhwB+UNMooYmzdkbNbaSW9uImrfGAbO6Ih 3B7Q12x7pRyGEEneIfUJdyKBHrsNs1lLdXVTw7isx4i/kLo1kQteEny1zex+4HjWQNbk KU3A==
X-Received by 10.66.165.8 with SMTP id yu8mr97907795pab.82.1435292650770; Thu, 25 Jun 2015 21:24:10 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 42
Organization linux.* mail to news gateway
X-Original-Cc devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date Fri, 26 Jun 2015 09:54:00 +0530
X-Original-Message-ID <20150626042400.GA15003@vaishali-Ideapad-Z570>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref aioe.org linux.kernel:1172586

Show key headers only | View raw


Use eth_zero_addr to assign the zero address to the given address
array instead of memset when second argument is address of zero.
Note that the 6 in the third argument of memset appears to represent
an ethernet address size (ETH_ALEN).

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@eth_zero_addr@
expression e;
@@

-memset(e,0x00,6);
+eth_zero_addr(e);
// </smpl>

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
index ea92fde..b89105d 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
@@ -112,7 +112,7 @@ static void TsAddBaProcess(unsigned long data)
 
 static void ResetTsCommonInfo(PTS_COMMON_INFO pTsCommonInfo)
 {
-	memset(pTsCommonInfo->Addr, 0, 6);
+	eth_zero_addr(pTsCommonInfo->Addr);
 	memset(&pTsCommonInfo->TSpec, 0, sizeof(TSPEC_BODY));
 	memset(&pTsCommonInfo->TClass, 0, sizeof(QOS_TCLAS)*TCLAS_NUM);
 	pTsCommonInfo->TClasProc = 0;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] Staging: rtl8192u: Replace memset with eth_zero_addr Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-06-26 06:30 +0200

csiph-web