Re: [PATCH v5 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Lu, Baolu" <baolu.lu@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend
Date	Fri, 26 Jun 2015 07:00:02 +0200
Message-ID	<pFtU6-5os-3@gated-at.bofh.it> (permalink)
References	<po1AR-2Ft-3@gated-at.bofh.it> <po1AS-2Ft-9@gated-at.bofh.it> <pFgNb-3rF-1@gated-at.bofh.it>
X-Original-To	Mathias Nyman <mathias.nyman@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mathias Nyman <mathias.nyman@intel.com>, Alan Stern <stern@rowland.harvard.edu>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.13,682,1427785200"; d="scan'208";a="595064530"
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 26 Jun 2015 12:52:10 +0800
X-Original-Message-ID	<558CDA7A.3070900@linux.intel.com>
X-Original-References	<1431134130-7922-1-git-send-email-baolu.lu@linux.intel.com> <1431134130-7922-4-git-send-email-baolu.lu@linux.intel.com> <558C15D5.9020802@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1172591

Show key headers only | View raw


On 06/25/2015 10:53 PM, Mathias Nyman wrote:
> On 09.05.2015 04:15, Lu Baolu wrote:
>> There is no need to call xhci_stop_device() and xhci_ring_device() in
>> hub control and bus suspend functions since all device suspend and
>> resume have been notified through device_suspend/device_resume interfaces.
> I was looking through this code again before sending it forward, and it occurred to
> me that this might be breaking the PORT_SUSPEND and PORT_SET_LINK_STATE port features
> for xhci root hub.
>
> In normal use these requests are called by usb core in usb_port_suspend(), which
> also now notifies xhci, which makes sure xhci_stop_device() is called.
>
> But I don't think there is anything preventing an URB to be sent to the xhci roothub
> with a PORT_SUSPEND or PORT_SET_LINK_STATE port feature request. In this case the usb_port_suspend()
> is not called, and no notify will stop the device.
>
> For example hub validation tests might do this.

If that, we can drop this patch. It doesn't impact the other two patches 
in this patch series.

Thanks,
Baolu
>
> -Mathias
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v5 3/3] usb: xhci: remove stop device and ring doorbell  in hub control and bus suspend "Lu, Baolu" <baolu.lu@linux.intel.com> - 2015-06-26 07:00 +0200

csiph-web