Re: [PATCH v2 16/17] libnvdimm: Add sysfs numa_node to NVDIMM devices

From	Toshi Kani <toshi.kani@hp.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 16/17] libnvdimm: Add sysfs numa_node to NVDIMM devices
Date	2015-06-26 04:30 +0200
Message-ID	<pFryV-2a2-17@gated-at.bofh.it> (permalink)
References	<pFbXc-4YO-11@gated-at.bofh.it> <pFbXe-4YO-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2015-06-25 at 05:37 -0400, Dan Williams wrote:
> From: Toshi Kani <toshi.kani@hp.com>
> 
> Add support of sysfs 'numa_node' to I/O-related NVDIMM devices
> under /sys/bus/nd/devices, regionN, namespaceN.0, and bttN.
> When bttN is not set up, its numa_node returns -1 (NUMA_NO_NODE).
> 
> An example of numa_node values on a 2-socket system with a single
> NVDIMM range on each socket is shown below.
>   /sys/bus/nd/devices
>   |-- btt0/numa_node:-1
>   |-- btt1/numa_node:0
>   |-- namespace0.0/numa_node:0
>   |-- namespace1.0/numa_node:1
>   |-- region0/numa_node:0
>   |-- region1/numa_node:1
> 
> These numa_node files are then linked under the block class of
> their device names.
>   /sys/class/block/pmem0/device/numa_node:0
>   /sys/class/block/pmem0s/device/numa_node:0
>   /sys/class/block/pmem1/device/numa_node:1
> 
> This enables numactl(8) to accept 'block:' and 'file:' paths of
> pmem and btt devices as shown in the examples below.
>   numactl --preferred block:pmem0 --show
>   numactl --preferred file:/dev/pmem0s --show
> 
> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Can you please update the commit log with the following?  It reflects
the changes in sysfs btt files.

Thanks,
-Toshi

=====
From: Toshi Kani <toshi.kani@hp.com>

Add support of sysfs 'numa_node' to I/O-related NVDIMM devices
under /sys/bus/nd/devices, regionN, namespaceN.0, and bttN.x.

An example of numa_node values on a 2-socket system with a single
NVDIMM range on each socket is shown below.
  /sys/bus/nd/devices
  |-- btt0.0/numa_node:0
  |-- btt1.0/numa_node:1
  |-- btt1.1/numa_node:1
  |-- namespace0.0/numa_node:0
  |-- namespace1.0/numa_node:1
  |-- region0/numa_node:0
  |-- region1/numa_node:1

These numa_node files are then linked under the block class of
their device names.
  /sys/class/block/pmem0/device/numa_node:0
  /sys/class/block/pmem1s/device/numa_node:1

This enables numactl(8) to accept 'block:' and 'file:' paths of
pmem and btt devices as shown in the examples below.
  numactl --preferred block:pmem0 --show
  numactl --preferred file:/dev/pmem1s --show

Signed-off-by: Toshi Kani <toshi.kani@hp.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 00/17] libnvdimm: ->rw_bytes(), BLK, BTT, PMEM api,  and unit tests Dan Williams <dan.j.williams@intel.com> - 2015-06-25 11:50 +0200
  [PATCH v2 16/17] libnvdimm: Add sysfs numa_node to NVDIMM devices Dan Williams <dan.j.williams@intel.com> - 2015-06-25 11:50 +0200
    Re: [PATCH v2 16/17] libnvdimm: Add sysfs numa_node to NVDIMM  devices Toshi Kani <toshi.kani@hp.com> - 2015-06-26 04:30 +0200
  [PATCH v2 06/17] fs/block_dev.c: skip rw_page if bdev has integrity Dan Williams <dan.j.williams@intel.com> - 2015-06-25 11:50 +0200
  [PATCH v2 14/17] acpi: Add acpi_map_pxm_to_online_node() Dan Williams <dan.j.williams@intel.com> - 2015-06-25 11:50 +0200
  [PATCH v2 12/17] pmem: flag pmem block devices as non-rotational Dan Williams <dan.j.williams@intel.com> - 2015-06-25 11:50 +0200
  [PATCH v2 11/17] libnvdimm: enable iostat Dan Williams <dan.j.williams@intel.com> - 2015-06-25 11:50 +0200

csiph-web