Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1172504

Re: [PATCH] modules: elide param_lock if !CONFIG_SYSFS

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Rusty,

On Fri, 26 Jun 2015 06:48:37 +0930 Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> Dan Streetman <ddstreet@ieee.org> writes:
> > Only include the built-in and per-module param_lock, and corresponding
> > lock/unlock functions, if sysfs is enabled.  If there is no sysfs there
> > is no need for locking kernel params.
> >
> > This fixes a build break when CONFIG_SYSFS is not enabled, introduced
> > by commit b51d23e.
> 
> This doesn't even come close to applying to my tree?

That's because (as Dan noted) there was another fix patch in the tree
he was fixing ...

> I've fixed it like so, and tested it compiles both with and without
> SYSFS.
> 
> Subject: param: fix module param locks when !CONFIG_SYSFS.
> 
> As Dan Streetman points out, the entire point of locking for is to
> stop sysfs accesses, so they're elided entirely in the !SYSFS case.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

Except the commit you added to the modules tree has no signed off by or
commentary :-(

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: linux-next: build failure after merge of the modules tree Dan Streetman <ddstreet@ieee.org> - 2015-06-25 12:00 +0200
  Re: [PATCH] modules: elide param_lock if !CONFIG_SYSFS Rusty Russell <rusty@rustcorp.com.au> - 2015-06-25 23:20 +0200
    Re: [PATCH] modules: elide param_lock if !CONFIG_SYSFS Dan Streetman <ddstreet@ieee.org> - 2015-06-25 23:40 +0200
    Re: [PATCH] modules: elide param_lock if !CONFIG_SYSFS Stephen Rothwell <sfr@canb.auug.org.au> - 2015-06-26 00:50 +0200

csiph-web