Re: [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats

From	Daniel Kiper <daniel.kiper@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats
Date	2015-06-25 23:40 +0200
Message-ID	<pFn2j-42w-45@gated-at.bofh.it> (permalink)
References	<pFiYF-6KG-17@gated-at.bofh.it> <pFiYG-6KG-29@gated-at.bofh.it> <pFke6-8sf-15@gated-at.bofh.it> <pFkxs-nq-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 25, 2015 at 08:54:45PM +0200, Daniel Kiper wrote:
> On Thu, Jun 25, 2015 at 08:38:36PM +0200, Daniel Kiper wrote:
> > On Thu, Jun 25, 2015 at 06:11:00PM +0100, David Vrabel wrote:
> > > The stats used for memory hotplug make no sense and are fiddled with
> > > in odd ways.  Remove them and introduce total_pages to track the total
> > > number of pages (both populated and unpopulated) including those within
> > > hotplugged regions (note that this includes not yet onlined pages).
> > >
> > > This will be useful when deciding whether additional memory needs to be
> > > hotplugged.
> > >
> > > Signed-off-by: David Vrabel <david.vrabel@citrix.com>
> >
> > Nice optimization! I suppose that it is remnant from very early
> > version of memory hotplug. Probably after a few patch series
> > iterations hotplug_pages and balloon_hotplug lost their meaning
> > and I did not catch it. Additionally, as I can see there is not
> > any consumer for total_pages here. So, I think that we can go
> > further and remove this obfuscated code at all.
>
> Err... Ignore that. I missed next patch... Should not both of them
> merged in one or commit comment contain clear info that this will
> be used by next patch.

This patch, #6 and probably #3 change reserve_additional_memory() behavior.
Please check comment before that function and update it accordingly.

It looks that balloon_stats.total_pages is used only in memory hotplug case.
Please do references (and definition) to it inside #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
like it is done in balloon_stats.hotplug_pages and balloon_stats.balloon_hotplug case.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCHv1 5/8] xen/balloon: rationalize memory hotplug stats Daniel Kiper <daniel.kiper@oracle.com> - 2015-06-25 23:40 +0200

csiph-web