Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1172466

Re: [PATCH] mm: meminit: Finish initialisation of struct pages before basic setup

From Nathan Zimmer <nzimmer@sgi.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mm: meminit: Finish initialisation of struct pages before basic setup
Date 2015-06-25 23:40 +0200
Message-ID <pFn2i-42w-39@gated-at.bofh.it> (permalink)
References <ppHRo-5xf-39@gated-at.bofh.it> <ppYfw-4TW-13@gated-at.bofh.it> <pF1Oa-6TC-15@gated-at.bofh.it> <pFmfU-2SE-9@gated-at.bofh.it> <pFmpA-33W-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jun 25, 2015 at 09:57:44PM +0100, Mel Gorman wrote:
> On Thu, Jun 25, 2015 at 09:48:55PM +0100, Mel Gorman wrote:
> > On Wed, Jun 24, 2015 at 05:50:28PM -0500, Nathan Zimmer wrote:
> > > My apologies for taking so long to get back to this.
> > > 
> > > I think I did locate two potential sources of slowdown.
> > > One is the set_cpus_allowed_ptr as I have noted previously.
> > > However I only notice that on the very largest boxes.
> > > I did cobble together a patch that seems to help.
> > > 
> > 
> > If you are using kthread_create_on_node(), is it even necessary to call
> > set_cpus_allowed_ptr() at all?
> > 
> 
> That aside, are you aware of any failure with this series as it currently
> stands in Andrew's tree that this patch is meant to address?  It seems
> like a nice follow-on that would boot faster on very large machines but
> if it's addressing a regression then it's very important as the series
> cannot be merged with known critical failures.
> 

Nope I haven't recorded any failures without it.
I just get concerned when I see some scaling issues that something COULD go wrong.


Nate

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] mm: meminit: Finish initialisation of struct pages  before basic setup Nathan Zimmer <nzimmer@sgi.com> - 2015-06-25 01:00 +0200
  Re: [PATCH] mm: meminit: Finish initialisation of struct pages  before basic setup Nathan Zimmer <nzimmer@sgi.com> - 2015-06-25 23:40 +0200
  Re: [PATCH] mm: meminit: Finish initialisation of struct pages  before basic setup Nathan Zimmer <nzimmer@sgi.com> - 2015-06-25 23:50 +0200

csiph-web