Groups > linux.kernel > #1172007

Re: [PATCH] SCSI-wd33c93: Deletion of a check before the function call "wd33c93_setup"

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] SCSI-wd33c93: Deletion of a check before the function call "wd33c93_setup"
Date	2015-06-25 12:00 +0200
Message-ID	<pFc6T-5a6-29@gated-at.bofh.it> (permalink)
References	(5 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <pEUWn-5yw-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 24, 2015 at 05:33:50PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 24 Jun 2015 17:15:17 +0200
> 
> The wd33c93_setup() function performs also input parameter validation.
> Thus the test around the call is not needed.
> 

Guys, you should be aware that Markus auto generates his patches and he
doesn't even do a cursory review.

"I find it acceptable that some of my update suggestions do not fit
to your quality expectations at the moment." -- Markus Elfring
(https://lkml.org/lkml/2015/1/22/446)

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] SCSI-wd33c93: Deletion of a check before the function  call "wd33c93_setup" Dan Carpenter <dan.carpenter@oracle.com> - 2015-06-25 12:00 +0200

csiph-web