Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1172004

[PATCH 1/1] scsi: remove check around pci_dev_put

From Maninder Singh <maninder1.s@samsung.com>
Newsgroups linux.kernel
Subject [PATCH 1/1] scsi: remove check around pci_dev_put
Date 2015-06-25 12:00 +0200
Message-ID <pFc6T-5a6-25@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


pci_dev_put checks for NULL Pointer itself.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
---
 drivers/scsi/eata_pio.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/eata_pio.c b/drivers/scsi/eata_pio.c
index ca8003f..481ecac 100644
--- a/drivers/scsi/eata_pio.c
+++ b/drivers/scsi/eata_pio.c
@@ -122,8 +122,7 @@ static int eata_pio_release(struct Scsi_Host *sh)
 			release_region(sh->io_port, sh->n_io_port);
 	}
 	/* At this point the PCI reference can go */
-	if (hd->pdev)
-		pci_dev_put(hd->pdev);
+	pci_dev_put(hd->pdev);
 	return 1;
 }
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 1/1] scsi: remove check around pci_dev_put Maninder Singh <maninder1.s@samsung.com> - 2015-06-25 12:00 +0200

csiph-web