Groups > linux.kernel > #1171950

Re: kexec_load(2) bypasses signature verification

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Dave Young <dyoung@redhat.com>
Newsgroups	linux.kernel
Subject	Re: kexec_load(2) bypasses signature verification
Date	Thu, 25 Jun 2015 10:50:01 +0200
Message-ID	<pFb17-3Dh-1@gated-at.bofh.it> (permalink)
References	<pC51T-3OF-9@gated-at.bofh.it> <pC5EC-4Oe-19@gated-at.bofh.it> <pCauC-3iI-13@gated-at.bofh.it> <pCaEi-3ui-7@gated-at.bofh.it> <pCwEN-1MB-1@gated-at.bofh.it> <pCxrb-2YR-7@gated-at.bofh.it> <pCIcV-1t5-19@gated-at.bofh.it> <pCXYl-7Dj-7@gated-at.bofh.it> <pCZGN-1Jh-13@gated-at.bofh.it> <pD4ds-8gO-17@gated-at.bofh.it>
X-Original-To	Vivek Goyal <vgoyal@redhat.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.22.1-rc1 (2013-10-16)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.27
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	"Eric W. Biederman" <ebiederm@xmission.com>, Josh Boyer <jwboyer@fedoraproject.org>, "Theodore Ts'o" <tytso@mit.edu>, Petr Tesarik <ptesarik@suse.cz>, kexec <kexec@lists.infradead.org>, "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>, David Howells <dhowells@redhat.com>
X-Original-Date	Thu, 25 Jun 2015 16:48:18 +0800
X-Original-Message-ID	<20150625084818.GB20085@dhcp-128-31.nay.redhat.com>
X-Original-References	<87zj3zigug.fsf@x220.int.ebiederm.org> <20150616202757.GB14943@redhat.com> <87y4jjglvu.fsf@x220.int.ebiederm.org> <20150617014737.GB30214@redhat.com> <20150618011629.GA8718@dhcp-128-32.nay.redhat.com> <20150618020209.GA8390@dhcp-128-32.nay.redhat.com> <20150618133044.GA1040@redhat.com> <20150619062140.GH4636@dhcp-128-32.nay.redhat.com> <20150619081816.GK4636@dhcp-128-32.nay.redhat.com> <20150619130933.GB13714@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1171950

Show key headers only | View raw

On 06/19/15 at 09:09am, Vivek Goyal wrote:
> On Fri, Jun 19, 2015 at 04:18:16PM +0800, Dave Young wrote:
> > > > If we want to disable unsigned kernel loading at compile time, then we
> > > > really need to work on decoupling CONFIG_KEXEC and CONFIG_FILE_KEXEC.
> > > > Introducing another config option is not the way forward, IMHO.
> > > 
> > > Yes, let's do it in this way since everyone is fine with it.
> > 
> > I will work on a patch if nobody else have interest or no time on it.
> 
> Thanks Dave. Will be good if you can get this done.

Vivek, I worked out some draft patches here:
https://github.com/daveyoung/linux/commits/kexec-syscall-cleanup

Basiclly I split kexec_file first, then add CONFIG_KEXEC_CORE kconfig option
then split kexec_load code from general code.

There's a lot of #ifdef CONFIG_KEXEC in kernel source, because CONFIG_KEXEC
can be disabled so I changed all kernel general and x86 #ifdef to use
CONFIG_KEXEC_CORE if necessary. For other arches dependent code with #ifdef
I did not change anything other than the new Kconfig option. It will works
because only x86 support KEXEC_FILE.

Please take a look if you have time, if this is not what you want please let
me know.

I will have no time this week, only did building test, will do more test next
week, if everything is ok I can send out the patches to list for review.

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: kexec_load(2) bypasses signature verification Dave Young <dyoung@redhat.com> - 2015-06-25 10:50 +0200
  Re: kexec_load(2) bypasses signature verification Dave Young <dyoung@redhat.com> - 2015-06-26 04:10 +0200

csiph-web