Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()
Date	2015-06-27 01:10 +0200
Message-ID	<pFKUV-4Dr-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <mSsDN-4wa-33@gated-at.bofh.it> <oq7O2-Pg-3@gated-at.bofh.it> <oq9wt-3ra-5@gated-at.bofh.it> <oqa9c-4wX-21@gated-at.bofh.it> <orbPA-nO-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 27, 2014 at 07:13:10PM +0100, Julia Lawall wrote:
> 
> 
> On Mon, 24 Nov 2014, SF Markus Elfring wrote:
> 
> > >> This issue was detected by using the Coccinelle software.
> > >
> > > What script was used ?
> >
> > A semantic patch approach which I published on the mailing lists in March
> > is in action on my software development system for a while.
> >
> >
> > > Is it in scripts/coccinelle ?
> >
> > Not yet.
> >
> > I hope that the involved update suggestions got sufficient positive feedback
> > to integrate five scripts there.
> 
> The current scripts are very complicated, involving the interaction
> between multiple scripts and a database, and I think they are not very
> suitable for make coccicheck.  Also, the idea of removing the null checks
> is not appropriate in all contexts.  Perhaps it could be possible to add
> a script to the Linux kernel that handles a number of common cases for
> which removing the null test is widely considered to be desirable.
> 
> julia
> 

Julia, do you have any particular objection to this specific patch? I didn't see
a reason to prevent it going in.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] platform: x86: Deletion of checks before  backlight_device_unregister() Darren Hart <dvhart@infradead.org> - 2015-06-27 01:10 +0200

csiph-web