Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1170363

Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node_put()

Show all headers | View raw

On 06/22/2015 09:30 PM, Srinivas Kandagatla wrote:
>
>
> On 22/06/15 15:54, Archit Taneja wrote:
>> Decrement device node refcount if of_get_child_by_name is successfully
>> called.
>>
>> Signed-off-by: Archit Taneja <architt@codeaurora.org>
>> ---
>>   drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> index de04009..1751659 100644
>> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> @@ -1582,6 +1582,8 @@ int msm_dsi_host_register(struct mipi_dsi_host
>> *host, bool check_defer)
>>               node = of_get_child_by_name(msm_host->pdev->dev.of_node,
>>                               "panel");
>>               if (node) {
>> +                of_node_put(node);
>> +
>
> Atleast from the current state of code, It looks like the driver is
> going to refer to the node of_node_put?, So I think this is not the
> right place to have of_node_put.

That's right. I made the same mistake in the later patches too. I'll fix 
these.

Thanks,
Archit

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node_put() Archit Taneja <architt@codeaurora.org> - 2015-06-23 07:10 +0200

csiph-web