[PATCH 1/1] scsi: remove redundant NULL check before kfree

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Maninder Singh <maninder1.s@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] scsi: remove redundant NULL check before kfree
Date	Tue, 23 Jun 2015 05:50:01 +0200
Message-ID	<pEnnH-7CE-3@gated-at.bofh.it> (permalink)
X-Original-To	JBottomley@odin.com, hare@suse.de, hch@lst.de, michaelc@cs.wisc.edu, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
X-Auditid	cbfee691-f79ca6d00000456a-81-5588d60a717d
X-Mailer	git-send-email 1.7.9.5
X-Brightmail-Tracker	H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsWyRsSkVpfrWkeowbPNghZ7Fk1isli5+iiT xf/1t1ksLu+aw2bRfX0Hm8Xh+W0sFsuP/2OyWPGmm9Hi3putTA6cHld/rWL22H2zgc3j8I8f zB4fn95i8ejbsorRY/Ppao/Pm+QC2KO4bFJSczLLUov07RK4Ml6v+8Ve8J6tomvlTrYGxg+s XYycHBICJhJ77hxlgbDFJC7cW8/WxcjFISSwlFGi6ddXFpiiplcgDSCJRYwSyw8sYYdwfjJK LHs9jw2kik1AT2LVrj1gHSICCxkl+h9rdjFycDALOElM/6oHYgoLOEtsOFMOUsEioCrRfP4C M0iYV8BdouNmDIgpIaAgMWeSDchwCYHp7BJ7f31jhigXkPg2+RALRI2sxKYDzBCXSUocXHGD ZQKj4AJGhlWMoqkFyQXFSelFpnrFibnFpXnpesn5uZsYgWF9+t+ziTsY7x+wPsQowMGoxMMr cLUjVIg1say4MvcQoynQhonMUqLJ+cDoySuJNzQ2M7IwNTE1NjK3NFMS59WR/hksJJCeWJKa nZpakFoUX1Sak1p8iJGJg1OqgfEAh4bcaiYjlU23QnTeXljQ5O76eLElh6ktm/GC3F+fy+Lf SH94fPHmwd+2S6fWaB16lVNTozrhlUeSvrvl1I0S/FxXb3NX2u7s+pnS2uq6/EBcmurZ9Mzy uV/2Lyn78YWD86v3q7OS/z2NHjxM3ZbiFLr7u1lyrnWjxgqjnSxGsu/1Kw2PVyqxFGckGmox FxUnAgDVsTNlZgIAAA==
X-Brightmail-Tracker	H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t9jAV2uax2hBq83cFnsWTSJyWLl6qNM Fv/X32axuLxrDptF9/UdbBaH57exWCw//o/JYsWbbkaLe2+2Mjlwelz9tYrZY/fNBjaPwz9+ MHt8fHqLxaNvyypGj82nqz0+b5ILYI9qYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1 tLQwV1LIS8xNtVVy8QnQdcvMATpNSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EB GkhYw5jxet0v9oL3bBVdK3eyNTB+YO1i5OSQEDCRaHoFY4tJXLi3nq2LkYtDSGARo8TyA0vY IZyfjBLLXs9jA6liE9CTWLVrDwuILSKwkFGi/7FmFyMHB7OAk8T0r3ogprCAs8SGM+UgFSwC qhLN5y8wg4R5BdwlOm7GgJgSAgoScybZTGDkXsDIsIpRNLUguaA4KT3XUK84Mbe4NC9dLzk/ dxMjOGqeSe1gXNlgcYhRgINRiYc34UJHqBBrYllxZe4hRgkOZiURXleQEG9KYmVValF+fFFp TmrxIUZToN0TmaVEk/OBEZ1XEm9obGJuamxqaWJhYmapJM57Mt8nVEggPbEkNTs1tSC1CKaP iYNTqoHR6fTUlk+d1b4PI4IOPp9nUJdrtXK19PyFEyeE1r3ifmrvXtETbWg1c3LzvNgta6/a 7vqwJ3vOJKaYr/wLFzr126RP38HMr+Cx9r3zitMmTHY7q+Uev1j33vf6h8kzZPn0y40XVmRd ltRw+tBxbBGn8oenHw7kMe6uSS+bMk9gbt152wVyN83rlFiKMxINtZiLihMBQ+eV8LACAAA=
Dlp-Filter	Pass
X-Mtr	20000000000000000@CPGS
X-Cfilter-Loop	Reflected
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	pankaj.m@samsung.com, Maninder Singh <maninder1.s@samsung.com>
X-Original-Date	Tue, 23 Jun 2015 09:12:30 +0530
X-Original-Message-ID	<1435030950-35999-1-git-send-email-maninder1.s@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1170356

Show key headers only | View raw

There is no need of NULL check before kfree,
So removing the same.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Rohit Thapliyal <r.thapliyal@samsung.com>
---
 drivers/scsi/aic94xx/aic94xx_init.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
index 4b135cc..a449fde 100644
--- a/drivers/scsi/aic94xx/aic94xx_init.c
+++ b/drivers/scsi/aic94xx/aic94xx_init.c
@@ -589,8 +589,7 @@ static void asd_destroy_ha_caches(struct asd_ha_struct *asd_ha)
 	if (asd_ha->hw_prof.scb_ext)
 		asd_free_coherent(asd_ha, asd_ha->hw_prof.scb_ext);
 
-	if (asd_ha->hw_prof.ddb_bitmap)
-		kfree(asd_ha->hw_prof.ddb_bitmap);
+	kfree(asd_ha->hw_prof.ddb_bitmap);
 	asd_ha->hw_prof.ddb_bitmap = NULL;
 
 	for (i = 0; i < ASD_MAX_PHYS; i++) {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/1] scsi: remove redundant NULL check before kfree Maninder Singh <maninder1.s@samsung.com> - 2015-06-23 05:50 +0200

csiph-web