Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1170353

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver

Path csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Yakir Yang <ykk@rock-chips.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver
Date Tue, 23 Jun 2015 05:10:01 +0200
Message-ID <pEmKZ-6Ru-7@gated-at.bofh.it> (permalink)
References <pD7bl-43o-13@gated-at.bofh.it> <pD7uF-4pU-3@gated-at.bofh.it> <pE6PT-wV-9@gated-at.bofh.it> <pE6Zz-I3-13@gated-at.bofh.it>
X-Original-To Russell King - ARM Linux <linux@arm.linux.org.uk>, Paul Bolle <pebolle@tiscali.nl>
X-263anti-Spam KSV:0;
X-Mail-Delivery 1
X-Abs-Checked 4
X-Rl-Sender ykk@rock-chips.com
X-Fst-To lgirdwood@gmail.com
X-Sender-IP 58.22.7.114
X-Login-Name ykk@rock-chips.com
X-Unique-Tag <8cab6d4d41df5cfe11a18ec1cfea5c9c>
X-Sender ykk@rock-chips.com
User-Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding 8bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 20
Organization linux.* mail to news gateway
X-Original-Cc linux-rockchip@lists.infradead.org, alsa-devel <alsa-devel@alsa-project.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-kernel@vger.kernel.org, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Doug Anderson <dianders@chromium.org>, David Airlie <airlied@linux.ie>, Philipp Zabel <p.zabel@pengutronix.de>, Andy Yan <andy.yan@rock-chips.com>, Daniel Kurtz <djkurtz@chromium.org>, Fabio Estevam <fabio.estevam@freescale.com>, Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>, Heiko Stuebner <heiko@sntech.de>, Liam Girdwood <lgirdwood@gmail.com>
X-Original-Date Tue, 23 Jun 2015 11:07:59 +0800
X-Original-Message-ID <5588CD8F.2040600@rock-chips.com>
X-Original-References <1434730417-10629-1-git-send-email-ykk@rock-chips.com> <1434731295-11060-1-git-send-email-ykk@rock-chips.com> <1434967564.31094.20.camel@x220> <20150622101038.GV7557@n2100.arm.linux.org.uk>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref aioe.org linux.kernel:1170353

Show key headers only | View raw


Russell,

在 2015/6/22 18:10, Russell King - ARM Linux 写道:
> On Mon, Jun 22, 2015 at 12:06:04PM +0200, Paul Bolle wrote:
>> But I think there's no platform_device with a "dw-hdmi-i2s-audio" name.
>> So I wonder whether this MODULE_ALIAS() is actually needed. What breaks
>> if you leave it out?
> +       } else if (hdmi_readb(hdmi, HDMI_CONFIG0_ID) & HDMI_CONFIG0_I2S) {
> +               pdevinfo.name = "dw-hdmi-ahb-audio";
>
> This should be "dw-hdmi-i2s-audio" to avoid picking up on my AHB audio
> driver.
Yep, thanks a lot ;)

- Yakir


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v5 4/6] drm: bridge/dw_hdmi-i2s-audio: add audio driver Yakir Yang <ykk@rock-chips.com> - 2015-06-23 05:10 +0200

csiph-web