Re: Re: [PATCH v2] perf probe: Fix failure to probe events on arm

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Newsgroups	linux.kernel
Subject	Re: Re: [PATCH v2] perf probe: Fix failure to probe events on arm
Date	Tue, 23 Jun 2015 05:10:01 +0200
Message-ID	<pEmKZ-6Ru-5@gated-at.bofh.it> (permalink)
References	<pCjxU-8bm-17@gated-at.bofh.it> <pCy3U-3Ni-3@gated-at.bofh.it> <pDbHY-2id-5@gated-at.bofh.it>
X-Original-To	Arnaldo Carvalho de Melo <acme@kernel.org>, He Kuang <hekuang@huawei.com>
Organization	Hitachi, Ltd., Japan
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
X-Original-Cc	a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, wangnan0@huawei.com, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 23 Jun 2015 12:07:25 +0900
X-Original-Message-ID	<5588CD6D.80503@hitachi.com>
X-Original-References	<5581578A.9060208@hitachi.com> <1434595750-129791-1-git-send-email-hekuang@huawei.com> <20150619210832.GB28405@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1170351

Show key headers only | View raw

On 2015/06/20 6:08, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jun 18, 2015 at 02:49:10AM +0000, He Kuang escreveu:
>> Fix failure to probe events on arm, problem is introduced by commit
>> 5a51fcd1f30c ("perf probe: Skip kernel symbols which is out of
>> .text"). For some architectures, label '_etext' is not in the .text
>> section(in .notes section for arm/arm64). Label out of .text section is
>> not loaded as symbols and we got a zero value when look up its address,
>> which causes all events be wrongly skiped.
>>
>> This patch skip checking text address range when failed to get the
>> address of '_etext' and fixes the problem.
> 
> Masami, since you guys discussed this patch, can I have your Acked-by?

Oops, I missed the mails..

OK I'll send it.

Thanks!

-- 
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: Re: [PATCH v2] perf probe: Fix failure to probe events on  arm Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> - 2015-06-23 05:10 +0200

csiph-web