Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support
Date	2015-06-24 10:50 +0200
Message-ID	<pEOxB-4Lc-21@gated-at.bofh.it> (permalink)
References	<pEwKm-4ev-13@gated-at.bofh.it> <pEwKn-4ev-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi, 

On Tue, Jun 23, 2015 at 07:14:57PM +0530, Sanchayan Maity wrote:
> +static struct nvmem_config ocotp_config = {
> +	.name = "soc_id",
> +};
> +
> +static struct nvmem_config rom_config = {
> +	.name = "rom_rev",
> +};

Srinivas, shouldn't we use the DT to setup these names, just like
clock-output-names does for example?

This is very likely to change from one board to another, and defining
a new compatible and/or driver for each board seems a bit fishy.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-06-24 10:50 +0200

csiph-web