Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1171181

Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

Show all headers | View raw

Hi David,

On Wed, 2015-06-24 at 01:44 -0700, David Miller wrote:
+AD4- From: Alexey Brodkin +ADw-Alexey.Brodkin+AEA-synopsys.com+AD4-
+AD4- Date: Wed, 24 Jun 2015 11:07:26 +-0300
+AD4- 
+AD4- +AD4-  
+AD4- +AD4- -           priv-+AD4-dma+AF8-tx +AD0- dma+AF8-alloc+AF8-coherent(priv-+AD4-device, 
+AD4- +AD4- txsize +ACo-
+AD4- +AD4- +-           priv-+AD4-dma+AF8-tx +AD0- dma+AF8-zalloc+AF8-coherent(priv-+AD4-device, 
+AD4- +AD4- txsize +ACo-
+AD4- +AD4-                                               sizeof(struct 
+AD4- +AD4- dma+AF8-desc),
+AD4- +AD4-                                               +ACY-priv
+AD4- +AD4- -+AD4-dma+AF8-tx+AF8-phy,
+AD4- +AD4-                                               GFP+AF8-KERNEL)+ADs-
+AD4- 
+AD4- When you change the column at which the openning parenthesis of the
+AD4- function call occurs, you must indent the subsequent lines of the
+AD4- function call such that the all are adjusted to properly start
+AD4- at the very next column after that openning parenthesis.'
+AD4- 
+AD4- Please fix this up for all of the dma+AF8-zalloc+AF8-coherent()
+AD4- transformations.

I thought about that and actually made this change initially but later
reverted it because I noticed dma+AF8-free+AF8-coherent() had parameters not
-aligned/idented properly.

So do you think if I may fix identation of dma+AF8-free+AF8-coherent() while at
it as well or I need to send a separate patch that takes care about
dma+AF8-free+AF8-coherent() solely?

-Alexey--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1 Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-06-24 10:10 +0200
  Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1 Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2015-06-24 10:40 +0200
  Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1 David Miller <davem@davemloft.net> - 2015-06-24 10:40 +0200

csiph-web