Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before the function call "kzfree"

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before the function call "kzfree"
Date	2015-06-24 09:50 +0200
Message-ID	<pENBw-3q6-5@gated-at.bofh.it> (permalink)
References	<mSsDN-4wa-35@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <pEDVx-6lY-25@gated-at.bofh.it> <pEEeT-6KU-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The other NULL assignment isn't useful either.  Also If
"entropy_collector" is NULL then we would oops calling
kzfree(entropy_collector->mem);
       ^^^^^^^^^^^^^^^^^^^^^^
Dereference.

I don't understand the patch that you sent.  We shouldn't be introducing
jent_zalloc() or jent_zfree().  Why are you adding abstractions there?
Quite bad ones as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before  the function call "kzfree" Dan Carpenter <dan.carpenter@oracle.com> - 2015-06-24 09:50 +0200
  Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before the function call "kzfree" Stephan Mueller <smueller@chronox.de> - 2015-06-24 10:00 +0200
    Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before  the function call "kzfree" Dan Carpenter <dan.carpenter@oracle.com> - 2015-06-24 11:20 +0200

csiph-web