Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1171004

Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma_one

Show all headers | View raw

On Wed, 2015-06-24 at 08:54 +0900, Kuninori Morimoto wrote:
> Can you please teach us about status of this patch ?
> > This adds a cast to the variables,slave_id_rx and slave_id_rx
> > to uintptr_t before casting to void* in order to avoid build
> > warning on 64bit platforms for the function, sh_mmcif_request_dma_one.
[]
> > diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
[]
> > @@ -398,8 +398,8 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host,
> >  
> >  	if (pdata)
> >  		slave_data = direction == DMA_MEM_TO_DEV ?
> > -			(void *)pdata->slave_id_tx :
> > -			(void *)pdata->slave_id_rx;
> > +			(void *)(uintptr_t)pdata->slave_id_tx :
> > +			(void *)(uintptr_t)pdata->slave_id_rx;

It's far more common (~10:1) in the kernel to cast using
	(<type> *)(unsigned long)<foo>
than
	(<type> *)(uintptr_t)<foo>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma_one Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> - 2015-06-24 02:00 +0200
  Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and  tx in the function, sh_mmcif_request_dma_one Joe Perches <joe@perches.com> - 2015-06-24 02:10 +0200
    Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and tx in the function, sh_mmcif_request_dma_one Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> - 2015-06-24 02:30 +0200
      Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and  tx in the function, sh_mmcif_request_dma_one Joe Perches <joe@perches.com> - 2015-06-24 02:50 +0200
        Re: [PATCHv2] mmc:Add pointer cast to uintptr_t for slave_id_rx and  tx in the function, sh_mmcif_request_dma_one Joe Perches <joe@perches.com> - 2015-06-24 03:00 +0200

csiph-web