Re: kdbus: to merge or not to merge?

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: kdbus: to merge or not to merge?
Date	Wed, 24 Jun 2015 01:30:02 +0200
Message-ID	<pEFNE-E2-5@gated-at.bofh.it> (permalink)
References	<pEpzc-2uw-1@gated-at.bofh.it>
X-Original-To	Andy Lutomirski <luto@amacapital.net>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=UIykYlLWDiigwNRGn+zaSZUoUc1rVYINcAUlN6nvDxc=; b=UqJdogeeGEUSTO05qTjl20mNy1icLytDk4PVSxVSd4MfHcIrEvs6+uAYuhHPPaZCqc 0G2wXY46JlWlkGAf2kjKugJ2QsKQ7Q0aQ/2NolRMxnqFG88Te5DJTH0ff14PAQixBmkE H+26msCyzWDtVY2sXJVuaZmxV/zGSUkfX9JFbpgv6vk9PwP+1lsdnfdFw+G/y6JQv196 NNXq7CAVUqfS0DbjVSLrh7K3n8S0oAZGzM1G3UhUP9n2+akyaIcUy+tyCby1gEX7rC7d bwfmdik9lEIicUd3vHTsLSIGNZRjrOvAy5cwWR/UTzJtU+m71Ali/Wt+GKmCM5djGLDE wEJQ==
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=UIykYlLWDiigwNRGn+zaSZUoUc1rVYINcAUlN6nvDxc=; b=cQ7Oo5V8CdNtG1GA/OU/SKhTGCC5MpkHYiicgDnfy/ILKMrvk6iFP/8KEeq8KYXc93 LXsFn+bQ3+Zu0i6wd7tCG1J5BAouI3LjKdb3n/MzWc7Tc5Io0HzxpCM8ubWoS4oCdNNO wsa8F41KnAF3MqgOtz1IKotqyfrFkFbvBfhtg=
MIME-Version	1.0
X-Received	by 10.107.27.7 with SMTP id b7mr46975193iob.64.1435101589468; Tue, 23 Jun 2015 16:19:49 -0700 (PDT)
X-Google-Sender-Auth	5U5jceiJSrjCLFmIApbZWcxLOeA
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, David Herrmann <dh.herrmann@gmail.com>, Djalal Harouni <tixxdz@opendz.org>, Greg KH <gregkh@linuxfoundation.org>, Havoc Pennington <havoc.pennington@gmail.com>, "Eric W. Biederman" <ebiederm@xmission.com>, One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>, Tom Gundersen <teg@jklm.no>, Daniel Mack <daniel@zonque.org>
X-Original-Date	Tue, 23 Jun 2015 16:19:49 -0700
X-Original-Message-ID	<CA+55aFwdk0FYXM=vmWhFye-dzgyBLUzKt40ujjEhKjjBLDwk7g@mail.gmail.com>
X-Original-References	<CALCETrW5sdcwM4zoX7BQdf+a2fWgQhd6rPDg8br0FU7Xy-2ZhQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1170995

Show key headers only | View raw

On Mon, Jun 22, 2015 at 11:06 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>
> Can you opine as to whether you think that kdbus should be merged?  I
> don't mean whether you'd accept a pull request that Greg may or may
> not send during this merge window -- I mean whether you think that
> kdbus should be merged if it had appropriate review and people were
> okay with the implementation.

So I am still expecting to merge it, mainly for a rather simple
reason: I trust my submaintainers, and Greg in particular. So when a
major submaintainer wants to merge something, that pulls a *lot* of
weight with me.

That said, I have to admit to being particularly disappointed with the
performance argument for merging it. Having looked at the dbus
performance, and come to the conclusion that the reason dbus performs
abysmally badly is just pure shit user space code, I am not AT ALL
impressed by the performance argument. We don't merge kernel code just
because user space was written by a retarded monkey on crack. Kernel
code has higher standards, and yes, that also means that it tends to
perform better, but no, "user space code is shit" is not a valid
reason for pushing things into the kernel.

So quite frankly, the "better performance" argument is bogus in my opinion.

That still leaves other arguments, but it does weaken the case for
kdbus quite a bit.

Because go out and read pretty much any argument for kdbus, and the
*first* argument is always performance. The articles never say "..
because the user-space dbus code is crap", though.

                       Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: kdbus: to merge or not to merge? Linus Torvalds <torvalds@linux-foundation.org> - 2015-06-24 01:30 +0200
  Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@amacapital.net> - 2015-06-24 03:00 +0200
  Re: kdbus: to merge or not to merge? Ingo Molnar <mingo@kernel.org> - 2015-06-24 10:10 +0200

csiph-web