Re: [PATCH] leds: lp5523: add master_fader support

Path	csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] leds: lp5523: add master_fader support
Date	Mon, 22 Jun 2015 14:00:04 +0200
Message-ID	<pE8yn-2Mp-37@gated-at.bofh.it> (permalink)
References	<pp1p8-1vn-17@gated-at.bofh.it> <ppcNA-1ox-17@gated-at.bofh.it> <ppdJG-2MP-35@gated-at.bofh.it> <ppecH-3m1-53@gated-at.bofh.it> <ppmDh-7xf-39@gated-at.bofh.it>
X-Original-To	Bryan Wu <cooloney@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	Jacek Anaszewski <j.anaszewski@samsung.com>, "Kim, Milo" <milo.kim@ti.com>, Toshi Kikuchi <toshik@chromium.org>, lkml <linux-kernel@vger.kernel.org>, Linux LED Subsystem <linux-leds@vger.kernel.org>
X-Original-Date	Mon, 22 Jun 2015 13:58:46 +0200
X-Original-Message-ID	<20150622115846.GA9179@xo-6d-61-c0.localdomain>
X-Original-References	<1431371454-2035-1-git-send-email-toshik@chromium.org> <5551AAFA.5080807@samsung.com> <5551B8F9.6040808@ti.com> <5551BF04.5010503@samsung.com> <CAK5ve-KkLmJMLs0Q3KskUodEJrjcWRx_tobVUm5+G=Q+_sFxmg@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1169882

Show key headers only | View raw

Hi!

> >>>> This patch introduces 4 new attributes:
> >>>>     master_fader_leds
> >>>>     master_fader1
> >>>>     master_fader2
> >>>>     master_fader3
> >>>>
> >>>> Fo example, to map channel 0,6 to master_fader1,
> >>>> map channel 1,7 to master_fader2,
> >>>> map channel 2,8 to master_fader3, and
> >>>> map channel 3,4,5 to none
> >>>
> >>>   >
> >>>>
> >>>>     echo "123000123" > master_fader_leds
> >>>
> >>>
> >>> I propose to add ABI documentation for this driver. It already exposes
> >>> many custom attributes but I can't find documentation for them.
> >>
> >>
> >> I agree with Jacek's comment but it would be better if we could see the
> >> description in lp5523 driver
> >> documentation(Documentation/leds/leds-lp5523.txt).
> >
> >
> > Right, I missed that file.
> >
> >
> 
> Toshi,
> 
> I merged this patch into my tree with Milo and Jacek Acks. But please
> follow their advice and provide a patch to update those document
> files.

Are you sure this is the right interface? lp5523 is turing-complete. Yes, it
can multiply brightness values by a constant. It can also do morse code on its
own, and compute prime numbers.

Why is this useful addition to kernel<->user interface?

Can we do better interface that works on more than one chip?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] leds: lp5523: add master_fader support Pavel Machek <pavel@ucw.cz> - 2015-06-22 14:00 +0200

csiph-web