Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1169884

Re: [git pull] vfs part 2

Show all headers | View raw

On 06/22/2015 12:12 AM, Al Viro wrote:
> On Thu, Apr 23, 2015 at 01:16:15PM +0300, Andrey Ryabinin wrote:
>> This change caused following:
> 
>> This could happen when p9pdu_readf() changes 'count' to some value > iov_iter_count(from):
>>
>> p9_client_write():
>> <...>
>> 		int count = iov_iter_count(from);
>> <...>
>> 		*err = p9pdu_readf(req->rc, clnt->proto_version, "d", &count);
>> <...>
>> 		iov_iter_advance(from, count);
> 
> *blink*
> 
> That's a bug, all right, but I would love to see how you trigger it.
> It would require server to respond to "write that many bytes" with "OK,
> <greater number> bytes written".  We certainly need to cope with that
> (we can't trust the server to be sane), but if that's what is going on,
> you've got a server bug as well.
> 
> Could you check if the patch below triggers WARN_ON() in it on your
> reproducer?  p9_client_read() has a similar issue as well...
> 

I've tried something like your patch before to check the read side
and I haven't seen anything before and don't see it right now.
Though, this doesn't mean that there is no problem with read.
I mean that trinity hits this on write and may just not hit this on read.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [git pull] vfs part 2 Andrey Ryabinin <a.ryabinin@samsung.com> - 2015-06-22 14:10 +0200
  Re: [git pull] vfs part 2 Andrey Ryabinin <a.ryabinin@samsung.com> - 2015-07-01 10:00 +0200
    Re: [git pull] vfs part 2 Al Viro <viro@ZenIV.linux.org.uk> - 2015-07-01 10:30 +0200
      Re: [git pull] vfs part 2 Andrey Ryabinin <a.ryabinin@samsung.com> - 2015-07-01 10:50 +0200
        Re: [git pull] vfs part 2 Al Viro <viro@ZenIV.linux.org.uk> - 2015-07-01 11:00 +0200
          Re: running out of tags in 9P (was Re: [git pull] vfs part 2) Al Viro <viro@ZenIV.linux.org.uk> - 2015-07-02 10:30 +0200
            Re: running out of tags in 9P (was Re: [git pull] vfs part 2) Al Viro <viro@ZenIV.linux.org.uk> - 2015-07-02 10:50 +0200
              Re: running out of tags in 9P (was Re: [git pull] vfs part 2) Andrey Ryabinin <a.ryabinin@samsung.com> - 2015-07-02 14:30 +0200
                Re: running out of tags in 9P (was Re: [git pull] vfs part 2) Al Viro <viro@ZenIV.linux.org.uk> - 2015-07-03 11:50 +0200
                [PATCH] forgetting to cancel request in interrupted zero-copy 9P RPC  (was Re: [git pull] vfs part 2) Al Viro <viro@ZenIV.linux.org.uk> - 2015-07-03 17:10 +0200

csiph-web