[PATCH v2] drivers: staging: rtl8712: remove unnecessary else statement

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Sunil Shahu <shshahu@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] drivers: staging: rtl8712: remove unnecessary else statement
Date	Mon, 22 Jun 2015 13:30:01 +0200
Message-ID	<pE85j-2e7-9@gated-at.bofh.it> (permalink)
References	<pD7XJ-5di-11@gated-at.bofh.it>
X-Original-To	gregkh@linuxfoundation.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4Ajqv/lhmea+99mPeseVFuC7Yh94T1ASz4UvdvAX3Iw=; b=X3mz+ChgZLRGRdnd7XipHPANd7cCh9BnYJIq5YGvifHtkTMaPa1yQrd0iASK13lkxX 5ojTipvAuZSOD5wYMHw6Gr/dWZxZKyL81uILE23xDRDRJ77kYunaGdSHH/X4DC/ryj7+ A1q3o37wq2yGdAKC8iahu0g5NoD2oJxTYA7OqzfVcee7dRQ3HfLrBKfVh4iDlXK1rSXd 0b7wgBTnXpidWvjMJIkvmBLTr+7DjOp8TN78vonkdCvE/NQXtzNScJFPaFGMf058kDse mgo7/iKjppibA/VU26tQ+OhIOSy+5rBN1HcZ4LwVQeqa/twPIFbEYP12T3sFDPB8ZUDI yAXQ==
X-Received	by 10.68.143.38 with SMTP id sb6mr58499925pbb.132.1434972574922; Mon, 22 Jun 2015 04:29:34 -0700 (PDT)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	62
Organization	linux.* mail to news gateway
X-Original-Cc	Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 22 Jun 2015 16:58:41 +0530
X-Original-Message-ID	<1434972521-6692-1-git-send-email-shshahu@gmail.com>
X-Original-References	<20150619170513.GA4291@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1169847

Show key headers only | View raw

"else" statement after "if" is unnecessary, hence removed.

Signed-off-by: Sunil Shahu <shshahu@gmail.com>
---
 drivers/staging/rtl8712/rtl871x_security.c | 35 ++++++++++++++----------------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
index bcd1a51..21465c9 100644
--- a/drivers/staging/rtl8712/rtl871x_security.c
+++ b/drivers/staging/rtl8712/rtl871x_security.c
@@ -124,28 +124,25 @@ static u8 crc32_reverseBit(u8 data)
 
 static void crc32_init(void)
 {
+	sint i, j;
+	u32 c = 0x12340000;
+	u8 *p = (u8 *)&c, *p1;
+	u8 k;
+
 	if (bcrc32initialized == 1)
 		return;
-	else {
-		sint i, j;
-		u32 c;
-		u8 *p = (u8 *)&c, *p1;
-		u8 k;
-
-		c = 0x12340000;
-		for (i = 0; i < 256; ++i) {
-			k = crc32_reverseBit((u8)i);
-			for (c = ((u32)k) << 24, j = 8; j > 0; --j)
-				c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY :
-				    (c << 1);
-			p1 = (u8 *)&crc32_table[i];
-			p1[0] = crc32_reverseBit(p[3]);
-			p1[1] = crc32_reverseBit(p[2]);
-			p1[2] = crc32_reverseBit(p[1]);
-			p1[3] = crc32_reverseBit(p[0]);
-		}
-		bcrc32initialized = 1;
+
+	for (i = 0; i < 256; ++i) {
+		k = crc32_reverseBit((u8)i);
+		for (c = ((u32)k) << 24, j = 8; j > 0; --j)
+			c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
+		p1 = (u8 *)&crc32_table[i];
+		p1[0] = crc32_reverseBit(p[3]);
+		p1[1] = crc32_reverseBit(p[2]);
+		p1[2] = crc32_reverseBit(p[1]);
+		p1[3] = crc32_reverseBit(p[0]);
 	}
+	bcrc32initialized = 1;
 }
 
 static u32 getcrc32(u8 *buf, u32 len)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2] drivers: staging: rtl8712: remove unnecessary else statement Sunil Shahu <shshahu@gmail.com> - 2015-06-22 13:30 +0200

csiph-web