Re: [PATCH v8 1/4] sched: Remove rq's runnable avg

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Yuyang Du <yuyang.du@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 1/4] sched: Remove rq's runnable avg
Date	Mon, 22 Jun 2015 08:20:02 +0200
Message-ID	<pE3fk-3OG-7@gated-at.bofh.it> (permalink)
References	<pBPzP-6HF-5@gated-at.bofh.it> <pBPzP-6HF-3@gated-at.bofh.it> <pD9d8-73z-19@gated-at.bofh.it>
X-Original-To	Dietmar Eggemann <dietmar.eggemann@arm.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.13,657,1427785200"; d="scan'208";a="592333004"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	"mingo@kernel.org" <mingo@kernel.org>, "peterz@infradead.org" <peterz@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "pjt@google.com" <pjt@google.com>, "bsegall@google.com" <bsegall@google.com>, Morten Rasmussen <Morten.Rasmussen@arm.com>, "vincent.guittot@linaro.org" <vincent.guittot@linaro.org>, "len.brown@intel.com" <len.brown@intel.com>, "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>, "fengguang.wu@intel.com" <fengguang.wu@intel.com>, "boqun.feng@gmail.com" <boqun.feng@gmail.com>, "srikar@linux.vnet.ibm.com" <srikar@linux.vnet.ibm.com>
X-Original-Date	Mon, 22 Jun 2015 06:26:01 +0800
X-Original-Message-ID	<20150621222601.GB3933@intel.com>
X-Original-References	<1434396367-27979-1-git-send-email-yuyang.du@intel.com> <1434396367-27979-2-git-send-email-yuyang.du@intel.com> <55845F0C.8050504@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1169704

Show key headers only | View raw

Hi Dietmar,

On Fri, Jun 19, 2015 at 07:27:24PM +0100, Dietmar Eggemann wrote:
> Hi Yuyang,
> 
> On 15/06/15 20:26, Yuyang Du wrote:
> > The current rq->avg is not used at all since its merge into kernel,
> > and the code is in the scheduler's hot path, so remove it.
> 
> are you sure that this is the case? I was always under the impression
> that w/ CONFIG_FAIR_GROUP_SCHED=y rq->avg (runnable_avg_sum, avg_period)
> is used to calculate contrib in __update_tg_runnable_avg() for the root
> group (cfs_rq->tg->css.id = 1).
> 
> On tg's w/ cfs_rq->tg->css.id > 1, se->avg (runnable_avg_sum,
> avg_period) is used instead but we simply don't have a tg related se for
> the root group. IMHO, that's why we have this rq::avg.
 
Yes, I agree. But the root group's avg is not useful anyway. If it is,
we sure should keep it.

> I understand that w/ the second patch in your series you don't need
> rq::avg any more.

And the rq->avg can be replaced by the root cfs_rq's util_avg, too.

Thanks,
Yuyang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v8 1/4] sched: Remove rq's runnable avg Yuyang Du <yuyang.du@intel.com> - 2015-06-22 08:20 +0200

csiph-web