Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1169702

[PATCH v2 5/6] Staging: comedi: ni_daq_dio24: Simplify a trivial if-return sequence

Show key headers only | View raw

From: Abdul Hussain <habdul@visteon.com>

This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.

Signed-off-by: Abdul Hussain <habdul@visteon.com>
---
 drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c
index a208cb3..d9de83a 100644
--- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
+++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
@@ -55,11 +55,7 @@ static int dio24_auto_attach(struct comedi_device *dev,
 
 	/* 8255 dio */
 	s = &dev->subdevices[0];
-	ret = subdev_8255_init(dev, s, NULL, 0x00);
-	if (ret)
-		return ret;
-
-	return 0;
+	return subdev_8255_init(dev, s, NULL, 0x00);
 }
 
 static struct comedi_driver driver_dio24 = {
-- 
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/6] Staging: comedi: dmm32at: Simplify a trivial if-return  sequence "Abdul, Hussain (H.)" <habdul@visteon.com> - 2015-06-22 08:20 +0200
  [PATCH v2 5/6] Staging: comedi: ni_daq_dio24: Simplify a trivial  if-return sequence "Abdul, Hussain (H.)" <habdul@visteon.com> - 2015-06-22 08:20 +0200
  [PATCH v2 2/6] Staging: comedi: fl512: Simplify a trivial if-return  sequence "Abdul, Hussain (H.)" <habdul@visteon.com> - 2015-06-22 08:20 +0200
  [PATCH v2 4/6] Staging: comedi: dac02: Simplify a trivial if-return  sequence "Abdul, Hussain (H.)" <habdul@visteon.com> - 2015-06-22 08:20 +0200
  [PATCH v2 3/6] Staging: combine: daqboard2000: Simplify a trivial  if-return sequence "Abdul, Hussain (H.)" <habdul@visteon.com> - 2015-06-22 08:20 +0200
    Re: [PATCH v2 3/6] Staging: combine: daqboard2000: Simplify a trivial  if-return sequence Markus Böhme <markus.boehme@mailbox.org> - 2015-06-22 22:50 +0200
  [PATCH v2 6/6] Staging: comedi: s626: Simplify a trivial if-return  sequence "Abdul, Hussain (H.)" <habdul@visteon.com> - 2015-06-22 08:20 +0200

csiph-web