[PATCH 1/5] staging: lustre: libcfs: drop trivially useless initialization

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Julia Lawall <Julia.Lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	[PATCH 1/5] staging: lustre: libcfs: drop trivially useless initialization
Date	Sat, 20 Jun 2015 21:20:02 +0200
Message-ID	<pDwt4-7lc-11@gated-at.bofh.it> (permalink)
References	<pDwt3-7lc-3@gated-at.bofh.it>
X-Original-To	Oleg Drokin <oleg.drokin@intel.com>
X-Ironport-Av	E=Sophos;i="5.13,650,1427752800"; d="scan'208";a="137169512"
X-Mailer	git-send-email 1.8.3.2
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	54
Organization	linux.* mail to news gateway
X-Original-Cc	kernel-janitors@vger.kernel.org, Andreas Dilger <andreas.dilger@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, HPDD-discuss@lists.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 20 Jun 2015 21:07:49 +0200
X-Original-Message-ID	<1434827273-13929-2-git-send-email-Julia.Lawall@lip6.fr>
X-Original-References	<1434827273-13929-1-git-send-email-Julia.Lawall@lip6.fr>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1169445

Show key headers only | View raw

Remove initialization of a variable that is immediately reassigned.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
type T;
identifier x;
constant C;
expression e;
@@

T x
- = C
 ;
x = e;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/staging/lustre/lustre/libcfs/fail.c       |    2 +-
 drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff -u -p a/drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c b/drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c
--- a/drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c
+++ b/drivers/staging/lustre/lustre/libcfs/libcfs_cpu.c
@@ -78,7 +78,7 @@ EXPORT_SYMBOL(cfs_cpt_table_free);
 int
 cfs_cpt_table_print(struct cfs_cpt_table *cptab, char *buf, int len)
 {
-	int	rc = 0;
+	int	rc;
 
 	rc = snprintf(buf, len, "%d\t: %d\n", 0, 0);
 	len -= rc;
diff -u -p a/drivers/staging/lustre/lustre/libcfs/fail.c b/drivers/staging/lustre/lustre/libcfs/fail.c
--- a/drivers/staging/lustre/lustre/libcfs/fail.c
+++ b/drivers/staging/lustre/lustre/libcfs/fail.c
@@ -123,7 +123,7 @@ EXPORT_SYMBOL(__cfs_fail_check_set);
 
 int __cfs_fail_timeout_set(__u32 id, __u32 value, int ms, int set)
 {
-	int ret = 0;
+	int ret;
 
 	ret = __cfs_fail_check_set(id, value, set);
 	if (ret) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/5] staging: lustre: libcfs: drop trivially useless initialization Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 21:20 +0200

csiph-web