Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1169401

[PATCH 05/12] staging: lustre: lmv: Use !x to check for kzalloc failure

Show all headers | View raw

!x is more normal for kzalloc failure in the kernel.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
statement S1, S2;
@@

x = kzalloc(...);
if (
- x == NULL
+ !x
 ) S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/staging/lustre/lustre/lmv/lmv_intent.c |    2 +-
 drivers/staging/lustre/lustre/lmv/lmv_obd.c    |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff -u -p a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
--- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
+++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
@@ -716,7 +716,7 @@ repeat_fid2path:
 	if (remote_gf == NULL) {
 		remote_gf_size = sizeof(*remote_gf) + PATH_MAX;
 		remote_gf = kzalloc(remote_gf_size, GFP_NOFS);
-		if (remote_gf == NULL) {
+		if (!remote_gf) {
 			rc = -ENOMEM;
 			goto out_fid2path;
 		}
@@ -1398,7 +1398,7 @@ static int lmv_statfs(const struct lu_en
 		return rc;
 
 	temp = kzalloc(sizeof(*temp), GFP_NOFS);
-	if (temp == NULL)
+	if (!temp)
 		return -ENOMEM;
 
 	for (i = 0; i < lmv->desc.ld_tgt_count; i++) {
@@ -1730,7 +1730,7 @@ lmv_enqueue_remote(struct obd_export *ex
 	}
 
 	rdata = kzalloc(sizeof(*rdata), GFP_NOFS);
-	if (rdata == NULL) {
+	if (!rdata) {
 		rc = -ENOMEM;
 		goto out;
 	}
diff -u -p a/drivers/staging/lustre/lustre/lmv/lmv_intent.c b/drivers/staging/lustre/lustre/lmv/lmv_intent.c
--- a/drivers/staging/lustre/lustre/lmv/lmv_intent.c
+++ b/drivers/staging/lustre/lustre/lmv/lmv_intent.c
@@ -100,7 +100,7 @@ static int lmv_intent_remote(struct obd_
 	}
 
 	op_data = kzalloc(sizeof(*op_data), GFP_NOFS);
-	if (op_data == NULL) {
+	if (!op_data) {
 		rc = -ENOMEM;
 		goto out;
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/12] Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:10 +0200
  [PATCH 04/12] staging: lustre: ldlm: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:10 +0200
  [PATCH 02/12] staging: lustre: fld: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:10 +0200
  [PATCH 07/12] staging: lustre: mdc: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:10 +0200
  [PATCH 03/12] staging: lustre: lclient: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:10 +0200
  [PATCH 11/12] staging: lustre: osc: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:20 +0200
  [PATCH 06/12] staging: lustre: lov: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:20 +0200
  [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:20 +0200
  [PATCH 09/12] staging: lustre: obdclass: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:20 +0200
    Re: [PATCH 09/12] staging: lustre: obdclass: Use !x to check for  kzalloc failure walter harms <wharms@bfs.de> - 2015-06-21 12:10 +0200
      Re: [PATCH 09/12] staging: lustre: obdclass: Use !x to check for  kzalloc failure Julia Lawall <julia.lawall@lip6.fr> - 2015-06-21 12:30 +0200
  [PATCH 10/12] staging: lustre: obdecho: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:20 +0200
  [PATCH 05/12] staging: lustre: lmv: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:20 +0200
  [PATCH 12/12] staging: lustre: ptlrpc: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:20 +0200
  [PATCH 08/12] staging: lustre: mgc: Use !x to check for kzalloc failure Julia Lawall <Julia.Lawall@lip6.fr> - 2015-06-20 19:20 +0200

csiph-web