Re: [PATCH 1/4] staging: sm750fb: use tabs for indentation

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Juston Li <juston.h.li@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] staging: sm750fb: use tabs for indentation
Date	Sat, 20 Jun 2015 17:50:02 +0200
Message-ID	<pDtbQ-28d-9@gated-at.bofh.it> (permalink)
References	<pDmDo-19F-5@gated-at.bofh.it> <pDmDo-19F-7@gated-at.bofh.it> <pDovw-3NE-17@gated-at.bofh.it>
X-Original-To	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=TRmYrZPyD6VJW546qnZSQf78OmR7qKZfBG5zkR6bIww=; b=HI6xKTQeLHzTxBMmZjhjdv71TRmDErQa2Cl94fW9Imy+GfaQ5HGq3/HwjSo/U/STb1 aV2Hw721XprZ9m5SCgfgLVPn7BaJttLAMh0j1IPfE2CAk/KvKQYM55RlCpr4W+83RWfI EKdKNJ8RdDKHR0tljPm3FpWp4l+miCa4g1Jma2stgSLFrrfmTY2Nvm98hoi44W4Zfzqm BDuPQKNTZR209Ff3JwcosUOgLlVOIJc9RMg/HJ/lUhTs2MMVVNMTuvzFk4XSsblNcC35 iS/fKSMd1CsrTU2fj1Lt6PTaQtAbwiWzLiKOOVfF+qev/xYscRPl0S/8PQEAFvfyuhOw 9rYQ==
MIME-Version	1.0
X-Received	by 10.182.230.75 with SMTP id sw11mr17769674obc.17.1434814820695; Sat, 20 Jun 2015 08:40:20 -0700 (PDT)
X-Google-Sender-Auth	Z0ag0bwFhdxu_n0yib6cxnPwUkA
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	teddy.wang@siliconmotion.com, Greg KH <gregkh@linuxfoundation.org>, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 20 Jun 2015 08:40:20 -0700
X-Original-Message-ID	<CAFow2F96vKxC5xLGo6kSd-iE0P7ru4FeXEKyywmr6ODkQBiT-g@mail.gmail.com>
X-Original-References	<CAFow2F83JesFGDeEPbcUsMHSuXjeYocZDWyjMfUON02hf3HbCg@mail.gmail.com> <1434790115-21683-1-git-send-email-juston.h.li@gmail.com> <20150620104505.GB29626@sudip-PC>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1169376

Show key headers only | View raw

My apologies, I thought I removed all of those. Fixed for real this
time, resending.

Regards
Juston

On Sat, Jun 20, 2015 at 3:45 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Sat, Jun 20, 2015 at 01:48:32AM -0700, Juston Li wrote:
>> Replace spaces with tabs for indentation to fix the checkpatch.pl error
>> ERROR: code indent should use tabs where possible
>> WARNING: please, no spaces at the start of a line
>>
>> Signed-off-by: Juston Li <juston.h.li@gmail.com>
>> ---
> <snip>
>> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
>> index b6395b8..c09748c 100644
>> --- a/drivers/staging/sm750fb/ddk750_sii164.c
>> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> <snip>
>>
>> @@ -279,27 +279,25 @@ char *sii164GetChipString(void)
>>   *  Input:
>>   *      powerUp - Flag to set the power down or up
>>   */
>> -void sii164SetPower(
>> -    unsigned char powerUp
>> -)
>> +void sii164SetPower(unsigned char powerUp)
> is it that same patch again? different kind of change should go in a separate patch.
>
> regards
> sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/4] staging: sm750fb: use tabs for indentation Juston Li <juston.h.li@gmail.com> - 2015-06-20 17:50 +0200

csiph-web