Re: [PATCH 2/2] gpio: altera: fix return value of altera_gpio_remove()

From	Alexandre Courbot <gnurou@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] gpio: altera: fix return value of altera_gpio_remove()
Date	2015-06-22 04:30 +0200
Message-ID	<pDZEJ-76O-7@gated-at.bofh.it> (permalink)
References	<pCkki-Ub-7@gated-at.bofh.it> <pCkki-Ub-37@gated-at.bofh.it> <pDHRv-6Nh-5@gated-at.bofh.it> <pDZEJ-76O-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 22, 2015 at 10:36 AM, Tien Hock Loh <thloh@altera.com> wrote:
> Sorry I was away from my mail for the past few weeks.
> This isn't intentional, should be a bug I overlook. The fix is correct.

Interestingly that has never been caught by reviewers despite 10
respins of your series!

Thanks for confirming.

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

>
> On Sun, 2015-06-21 at 16:25 +0900, Alexandre Courbot wrote:
>> On Wed, Jun 17, 2015 at 8:59 PM, Masahiro Yamada
>> <yamada.masahiro@socionext.com> wrote:
>> > The remove callback never succeeds, which seems odd.
>> >
>> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> > ---
>> >
>> > I wonder why nobody has pointed this out before me.
>> > I am suspecting -EIO might be intentional.
>> > I hope some Altera guys will give me comments.
>> >
>> >
>> >  drivers/gpio/gpio-altera.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
>> > index c653c83..5861550 100644
>> > --- a/drivers/gpio/gpio-altera.c
>> > +++ b/drivers/gpio/gpio-altera.c
>> > @@ -339,7 +339,7 @@ static int altera_gpio_remove(struct platform_device *pdev)
>> >
>> >         of_mm_gpiochip_remove(&altera_gc->mmchip);
>> >
>> > -       return -EIO;
>> > +       return 0;
>>
>> That looks weird indeed. Tien, can you comment on this?
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] gpio: altera: fix return value of altera_gpio_remove() Alexandre Courbot <gnurou@gmail.com> - 2015-06-22 04:30 +0200

csiph-web