Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions

From	Robert Jarzmik <robert.jarzmik@free.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions
Date	2015-06-21 20:10 +0200
Message-ID	<pDRQR-4iT-11@gated-at.bofh.it> (permalink)
References	<p6B05-2D9-5@gated-at.bofh.it> <p6B05-2D9-11@gated-at.bofh.it> <pDr0m-7yt-3@gated-at.bofh.it> <pDyXU-2oo-7@gated-at.bofh.it> <pDQ8q-1I3-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:

> On Sat, 20 Jun 2015, Robert Jarzmik wrote:
>
>> Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
>> 
>> >> +static void pxa_camera_dma_irq(struct pxa_camera_dev *pcdev,
>> >> +			       enum pxa_camera_active_dma act_dma);
>> >> +
>> >> +static void pxa_camera_dma_irq_y(void *data)
>> >
>> > Wait, how is this patch trivial? You change pxa_camera_dma_irq_?() 
>> > prototypes, which are used as PXA DMA callbacks. Does this mean, that 
>> > either before or after this patch compilation is broken?
>> 
>> Jeez you're right.
>> So I can either fold that with patch 4, or try to rework it somehow ...
>
> How about letting that patch do exactly what it says it does? Just move 
> functions up in the file if you need them there, without changing them, 
> and only change them when it's needed?
Deal, for next iteration.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions Guennadi Liakhovetski <g.liakhovetski@gmx.de> - 2015-06-21 18:20 +0200
  Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions Robert Jarzmik <robert.jarzmik@free.fr> - 2015-06-21 20:10 +0200

csiph-web