Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1169623

Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 06/21/2015 06:50 PM, Oliver Hartkopp wrote:
> As reported by Manfred Schlaegl here
> 
>    http://marc.info/?l=linux-netdev&m=143482089824232&w=2
> 
> commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for
> overlapping CAN filters" requires the skb->tstamp to be set to check for
> identical CAN skbs.
> 
> As net timestamping is influenced by several players (netstamp_needed and
> netdev_tstamp_prequeue) Manfred missed a proper timestamp which leads to
> CAN frame loss.
> 
> As skb timestamping became now mandatory for CAN related skbs this patch
> makes sure that received CAN skbs always have a proper timestamp set.
> Maybe there's a better solution in the future but this patch fixes the
> CAN frame loss so far.
> 
> Reported-by: Manfred Schlaegl <manfred.schlaegl@gmx.at>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>

I'll send a pullrequest to David asap, I'll add stable on Cc if this
doesn't make it into v4.1 anymore.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv Oliver Hartkopp <socketcan@hartkopp.net> - 2015-06-21 19:00 +0200
  Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in  raw_rcv Marc Kleine-Budde <mkl@pengutronix.de> - 2015-06-21 19:00 +0200
    Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv Oliver Hartkopp <socketcan@hartkopp.net> - 2015-06-21 19:20 +0200
  Re: [PATCH - regression 4.1-rc8] can: fix loss of CAN frames in raw_rcv Manfred Schlaegl <manfred.schlaegl@gmx.at> - 2015-06-22 13:50 +0200

csiph-web