Re: [PATCH v2] futex: lower the lock contention on the HB lock during wake up

From	Mike Galbraith <umgwanakikbuti@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] futex: lower the lock contention on the HB lock during wake up
Date	2015-06-21 06:40 +0200
Message-ID	<pDFd0-2YG-11@gated-at.bofh.it> (permalink)
References	(2 earlier) <pC4Iy-3oZ-9@gated-at.bofh.it> <pC5bA-40P-23@gated-at.bofh.it> <pCh34-4u4-9@gated-at.bofh.it> <pCmm6-3M8-21@gated-at.bofh.it> <pCmvL-3Xc-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2015-06-17 at 16:28 +0200, Sebastian Andrzej Siewior wrote:
> On 06/17/2015 04:17 PM, Mike Galbraith wrote:
> > On Wed, 2015-06-17 at 10:33 +0200, Sebastian Andrzej Siewior wrote:
> >> wake_futex_pi() wakes the task before releasing the hash bucket lock
> >> (HB). The first thing the woken up task usually does is to acquire the
> >> lock which requires the HB lock. On SMP Systems this leads to blocking
> >> on the HB lock which is released by the owner shortly after.
> >> This patch rearranges the unlock path by first releasing the HB lock and
> >> then waking up the task.
> >>
> >> [bigeasy: redo ontop of lockless wake-queues]
> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> >> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > 
> > 4.1-rc8-rt4 contains this via 4.0-rt4, and seems fine on my 64 core
> > DL980.  I ran a few iterations of futextests and stockfish, then mixed
> > two loops of futextest at different rt prios, with stockfish also rt,
> > and ltplight as tossed in as... crack filler.  Box is still doing that,
> > is way too busy, but not griping about it.  
> 
> There are two patches mostly doing the same thing. The patch posted
> here is a redo ontop of "lockless wake-queues". It does hb-unlock,
> wakeup, de-boost. The patch merged into -RT is the original approach
> not using "lockless wake-queues" and performing wakeup, hb-unlock,
> de-boost.
> 
> I plan to get into -RT the final solution once it hits upstream.

I plugged patch1 and tip version into rt and beat it, seems solid.

Converting the rest of rtmutex.c to use wake queues with ->save_state to
select wake function went less well.  Kernel does a good impersonation
of a working kernel until I beat it up, then it loses wakeups.  Hohum,
so much for yet another early morning tinker session.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] futex: lower the lock contention on the HB lock during wake  up Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-06-16 21:30 +0200
  Re: [PATCH] futex: lower the lock contention on the HB lock during  wake up Davidlohr Bueso <dave@stgolabs.net> - 2015-06-16 22:00 +0200
    Re: [PATCH v2] futex: lower the lock contention on the HB lock  during wake up Mike Galbraith <umgwanakikbuti@gmail.com> - 2015-06-21 06:40 +0200

csiph-web