Re: [PATCH] Bluetooth: btusb: Add Realtek devices into module device table

From	Larry Finger <Larry.Finger@lwfinger.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Bluetooth: btusb: Add Realtek devices into module device table
Date	2015-06-21 03:20 +0200
Message-ID	<pDC5s-6YN-11@gated-at.bofh.it> (permalink)
References	<pDyXU-2oo-5@gated-at.bofh.it> <pDyXU-2oo-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/20/2015 04:58 PM, Marcel Holtmann wrote:
> Hi Xi,
>
>> In 'commit a2698a9bf9b0 ("Bluetooth: btusb: Add Realtek
>> 8723A/8723B/8761A/8821A support"), support of some Realtek
>> devices was added to the Generic Bluetooth USB driver in kernel.
>> However, these devices are not in the module device table of
>> btusb.ko, so the kernel wouldn't probe them at all.
>>
>> To fix this, add four entries in the device table btusb_table,
>> based on code from <https://github.com/lwfinger/rtl8723au_bt>
>> ('new' branch).
>>
>> This enables bluetooth support in the Lenovo Ideapad Yoga 13
>> which has RTL8723AU USB device, with product ID 0bda:1724.
>>
>> Signed-off-by: Xi Ruoyao <xry111@outlook.com>
>> ---
>> drivers/bluetooth/btusb.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index 3c10d4d..dd87623 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -148,6 +148,12 @@ static const struct usb_device_id btusb_table[] = {
>> 	{ USB_DEVICE(0x8087, 0x0a5a),
>> 	  .driver_info = BTUSB_INTEL_BOOT | BTUSB_BROKEN_ISOC },
>>
>> +	/* Realtek Bluetooth  */
>> +	{ USB_VENDOR_AND_INTERFACE_INFO(0x0bda, 0xe0, 0x01, 0x01) },
>> +	{ USB_VENDOR_AND_INTERFACE_INFO(0x0bd5, 0xe0, 0x01, 0x01) },
>> +	{ USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xe0, 0x01, 0x01) },
>> +	{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xe0, 0x01, 0x01) },
>> +
>
> I highly doubt these are needed. There is a generic entry for an USB transport that is already covering these.

Something changed in recent kernels, and the generic USB transport entries do 
not seem to be recognized in the case where a wifi and BT device share a single 
USB ID. As the OP's tablet has such a case, I suggest that 0bda line be 
accepted, but not the others. If I had a computer with an RTL8723AU, I would 
have a chance at debugging what changed, but sadly, that is not the case.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] Bluetooth: btusb: Add Realtek devices into module device  table Larry Finger <Larry.Finger@lwfinger.net> - 2015-06-21 03:20 +0200
  Re: [PATCH] Bluetooth: btusb: Add Realtek devices into module device  table Xi Ruoyao <xry111@outlook.com> - 2015-06-21 06:20 +0200
    Re: [PATCH] Bluetooth: btusb: Add Realtek devices into module device  table Xi Ruoyao <xry111@outlook.com> - 2015-06-21 06:30 +0200
  Re: [PATCH] Bluetooth: btusb: Add Realtek devices into module device  table Xi Ruoyao <xry111@outlook.com> - 2015-06-22 14:10 +0200

csiph-web