Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA

From	Paul Gortmaker <paul.gortmaker@windriver.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA
Date	2015-06-21 02:20 +0200
Message-ID	<pDB9o-5Fg-3@gated-at.bofh.it> (permalink)
References	<pCImB-1Ew-3@gated-at.bofh.it> <pD5sR-1yD-5@gated-at.bofh.it> <pDxIt-B1-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jun 20, 2015 at 4:32 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> On Fri, Jun 19, 2015 at 10:24 AM, Herbert Xu
> <herbert@gondor.apana.org.au> wrote:
>> On Thu, Jun 18, 2015 at 03:46:16PM +0200, Boris Brezillon wrote:
>>> Hello,
>>>
>>> This patch series adds a new driver supporting Marvell's CESA IP.
>>> This driver addresses some limitations of the existing one.
>>> >From a performance and CPU load point of view the most important
>>> limitation in the existing driver is the lack of DMA support, thus
>>> preventing us from chaining crypto operations.
>>
>> All applied to cryptodev.  Thanks a lot!
>
> It seems this breaks linux-next allmodconfig on i386:

Similar breakage for s390 and sparc it seems:

drivers/crypto/marvell/cesa.c:353:2: error: implicit declaration of
function 'phys_to_dma' [-Werror=implicit-function-declaration]

http://kisskb.ellerman.id.au/kisskb/buildresult/12445415/
http://kisskb.ellerman.id.au/kisskb/buildresult/12445345/

If the CESA IP is only available on a single arch then
adding an arch dependency might be the easiest fix,
since phys_to_dma seems sparsely implemented.

Paul.
--

>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12445342/
>
> ERROR: "phys_to_dma" [drivers/crypto/marvell/marvell-cesa.ko] undefined!
> make[2]: *** [__modpost] Error 1
>
> Paul.
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-06-21 02:20 +0200
  Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-06-21 10:30 +0200
    Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-21 10:40 +0200
      Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-06-21 17:40 +0200

csiph-web