Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1168652

Re: [-next] !irqd_can_balance() WARNINGs at irq_move_masked_irq()

Show all headers | View raw

On Fri, 19 Jun 2015, Sergey Senozhatsky wrote:
> [    0.412291] WARNING: CPU: 0 PID: 0 at kernel/irq/migration.c:21 irq_move_masked_irq+0x57/0xc4()
> [    0.412371] Can't balance irq 0 [edge]

Yuck.

> Do you guys want to replace WAN_ON() with WARN_ONCE(), perhaps? This, of course,
> doesn't fix anything; but at least one can boot the system. (not really a patch,
> just an idea).

Indeed. We really want to clear the move pending bit before the can
balance check. Patch below. But that does not explain why this happens
in the first place.

Can you please send me a full dmesg, kernel config and output of
/proc/interrupts ? (Private mail is fine, or upload it to some place)

Thanks,

	tglx
---
diff --git a/kernel/irq/migration.c b/kernel/irq/migration.c
index dd203e276b07..8cf8c24afaab 100644
--- a/kernel/irq/migration.c
+++ b/kernel/irq/migration.c
@@ -12,16 +12,19 @@ void irq_move_masked_irq(struct irq_data *idata)
 	if (likely(!irqd_is_setaffinity_pending(&desc->irq_data)))
 		return;
 
+	irqd_clr_move_pending(&desc->irq_data);
+
 	/*
 	 * Paranoia: cpu-local interrupts shouldn't be calling in here anyway.
 	 */
 	if (!irqd_can_balance(&desc->irq_data)) {
-		WARN_ON(1);
+		pr_warn("Cannot move irq %d: %s\n",
+			desc->irq_data.irq,
+			irqd_is_per_cpu(&desc->irq_data) ?
+			"per cpu" : "balancing disabled");
 		return;
 	}
 
-	irqd_clr_move_pending(&desc->irq_data);
-
 	if (unlikely(cpumask_empty(desc->pending_mask)))
 		return;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[-next] !irqd_can_balance() WARNINGs at irq_move_masked_irq() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-06-19 09:20 +0200
  Re: [-next] !irqd_can_balance() WARNINGs at irq_move_masked_irq() Thomas Gleixner <tglx@linutronix.de> - 2015-06-19 11:30 +0200
    Re: [-next] !irqd_can_balance() WARNINGs at irq_move_masked_irq() Thomas Gleixner <tglx@linutronix.de> - 2015-06-19 14:30 +0200
      Re: [-next] !irqd_can_balance() WARNINGs at irq_move_masked_irq() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-06-19 15:20 +0200
      Re: [-next] !irqd_can_balance() WARNINGs at irq_move_masked_irq() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-06-20 06:40 +0200
        Re: [-next] !irqd_can_balance() WARNINGs at irq_move_masked_irq() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-06-20 20:00 +0200
        Re: [-next] !irqd_can_balance() WARNINGs at irq_move_masked_irq() Thomas Gleixner <tglx@linutronix.de> - 2015-06-21 16:40 +0200
          [tip:x86/apic] x86/hpet:   Use proper hpet device number for MSI allocation tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2015-06-21 16:50 +0200

csiph-web