Re: [PATCH 3/3] writeback, blkio: add documentation for cgroup writeback support

From	Theodore Ts'o <tytso@mit.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] writeback, blkio: add documentation for cgroup writeback support
Date	2015-06-17 23:50 +0200
Message-ID	<pCtnz-5nI-3@gated-at.bofh.it> (permalink)
References	(3 earlier) <pBHiV-30B-15@gated-at.bofh.it> <pBM8W-1DN-21@gated-at.bofh.it> <pC73I-6Hz-13@gated-at.bofh.it> <pCc3o-5HM-1@gated-at.bofh.it> <pCqJ5-1sH-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 17, 2015 at 02:52:37PM -0400, Tejun Heo wrote:
> 
> Hmmm... so, overriding things *before* an bio is issued shouldn't be
> too difficult and as long as this sort of operations aren't prevalent
> we might be able to get away with just charging them against root.
> Especially if it's to avoid getting blocked on the journal which we
> already consider a shared overhead which is charged to root.  If this
> becomes large enough to require exacting charges, it'll be more
> complex but still way better than trying to raise priority on a bio
> which is already issued, which is likely to be excruciatingly painful
> if possible at all.

Yeah, just charging the overhead to root seems good enough.

I could imagine charging it to whatever cgroup the jbd/jbd2 thread
belongs to, which in turn would be the cgroup of the process that
mounted the file system.  The only problem with that is that if a
low-priority process is allowed to mount a file system, and it gets
traversed by a high priority process, the high priority process will
get impacted.  So maybe it's better to just say that it always get
charged to the root cgroup.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] writeback, blkio: add documentation for cgroup  writeback support Theodore Ts'o <tytso@mit.edu> - 2015-06-16 01:40 +0200
  Re: [PATCH 3/3] writeback, blkio: add documentation for cgroup  writeback support Tejun Heo <tj@kernel.org> - 2015-06-17 00:00 +0200
    Re: [PATCH 3/3] writeback, blkio: add documentation for cgroup  writeback support Theodore Ts'o <tytso@mit.edu> - 2015-06-17 23:50 +0200

csiph-web